Skip to content

Issue 2256 - facility analysis validation water/energy reduction goal#2268

Merged
rmroot merged 1 commit intodevelopfrom
issue-2256
Feb 26, 2026
Merged

Issue 2256 - facility analysis validation water/energy reduction goal#2268
rmroot merged 1 commit intodevelopfrom
issue-2256

Conversation

@jamlokim
Copy link
Copy Markdown
Contributor

connects #2256

This pull request primarily improves the user interface and error handling for the analysis details tables in both the account and facility analysis dashboards. The changes focus on enhancing user feedback, clarifying error conditions, and improving code readability and maintainability in the HTML templates and TypeScript logic.

User Interface Improvements:

  • Updated empty state and filter feedback messages to use Bootstrap alert styling for better visibility and consistency (account-analysis-details-table.component.html, analysis-details-table.component.html).
  • Improved the alignment and formatting of action buttons, pagination, and modal content for a cleaner and more consistent UI (analysis-details-table.component.html).

Error Handling and Logic Enhancements:

  • Refined the baseline year error checks to only apply when the relevant reduction goal is set, preventing unnecessary error states (analysis-details-table.component.ts).
  • Simplified and clarified the error condition logic for displaying the main analysis table, ensuring correct behavior when baseline year errors are present (analysis-details-table.component.html).

Code Readability and Maintainability:

  • Cleaned up and reformatted template code for better readability, including consistent spacing and indentation in the display of analysis items and action buttons
    These changes collectively make the analysis dashboard more user-friendly and robust, while also making the code easier to maintain.

@jamlokim jamlokim requested a review from rmroot February 25, 2026 20:58
@rmroot rmroot merged commit f5e1b90 into develop Feb 26, 2026
3 checks passed
@jamlokim jamlokim deleted the issue-2256 branch March 25, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants