Issue-2254: fix date setting in meter data form#2267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connects #2254
This pull request primarily addresses improvements in date parsing for meter data forms and includes minor code cleanups. The most significant changes are focused on how date values are handled when updating meter data, replacing JavaScript
Dateobject parsing with explicit string splitting and parsing. Additionally, there are minor removals of unused code and console logs.Date parsing improvements:
updateElectricityMeterDataFromFormandupdateGeneralMeterDataFromForminutility-meter-data.service.tsto use string splitting andparseIntinstead of the JavaScriptDateconstructor, improving reliability and clarity of date extraction. [1] [2]Code cleanup:
console.logstatement from theEditBillComponentto clean up debug output.IdbCustomGWPfromedit-electricity-bill.component.tsto tidy up imports.