Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connects #2190
This pull request updates the calendarization and analysis calculation logic to support passing custom Global Warming Potentials (GWPs) throughout the application. The changes primarily involve updating function signatures and internal calls to accept and propagate an array of custom GWPs, as well as refactoring the usage of the
assessmentReportVersionparameter to use a dedicated type. Additionally, there are improvements to the initialization of custom GWPs in the app component.Support for custom GWPs in calendarization and analysis calculations:
Updated the
getCalanderizedMeterDatafunction and all related calendarization functions (calanderizeMeterData,calanderizeMeterDataBackwards,calanderizeMeterDataFullMonth,calanderizeFullYear,getBillPeriodTotal) to accept and propagate an array ofIdbCustomGWPobjects, allowing custom GWPs to be used in emissions calculations. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]Updated all calls to
getCalanderizedMeterDatain analysis and report classes (MonthlyAccountAnalysisClass,BetterPlantsReportClass) to include the newcustomGWPsparameter, ensuring custom GWPs are available throughout the analysis pipeline. [1] [2] [3]Refactoring and type improvements:
assessmentReportVersionparameters with theAssessmentReportVersiontype throughout the codebase for improved type safety and maintainability. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Custom GWP initialization improvements:
initializeCustomGWPsmethod inAppComponentto update and persist any changed custom GWPs before broadcasting them, ensuring the latest values are always used.