Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connects #799
This pull request introduces responsive improvements to the navigation tabs in the account banner and account overview banner components, ensuring a better user experience on smaller screens. It also refactors and cleans up related code, and applies various CSS enhancements for improved layout and usability.
Responsive navigation and UI improvements:
AccountBannerComponentandAccountOverviewBannerComponentto dynamically hide or show tab text based on available width, using@ViewChild,HostListener, and newhideTabText/hideAllTextstate variables. This ensures tabs remain usable on smaller screens. [1] [2] [3] [4] [5]span.nav-textand conditionally apply CSS classes for hiding/showing text, improving responsiveness and accessibility. [1] [2]CSS and layout enhancements:
white-space: nowrapfor buttons and backup info, and making the navbar horizontally scrollable if needed. [1] [2] [3]Code cleanup and refactoring:
AccountOverviewBannerComponent, including date range selection, emissions/source toggles, and related subscriptions, in favor of a newapp-account-overview-optionscomponent. [1] [2] [3] [4] [5]These changes collectively improve the adaptability, maintainability, and user experience of the account navigation components.