Issue 2131 - highlight rows with missing data#2209
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request enhances the analysis summary functionality to identify, track, and visually highlight rows with missing predictor data at both monthly and annual levels. The implementation adds a missingPredictors array property to track missing predictor variable IDs throughout the analysis pipeline, from data calculations to UI display.
Changes:
- Added
missingPredictorsarray to data models (MonthlyAnalysisSummaryDataandAnnualAnalysisSummary) to track missing predictor variable IDs - Implemented logic to detect and aggregate missing predictors across monthly and annual summaries
- Enhanced UI tables with visual indicators (exclamation icons and row highlighting) to identify missing data
- Added input properties (
isAccount,inReport,groupSummaries,group) to table components to support context-aware display logic
Reviewed changes
Copilot reviewed 29 out of 30 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/app/models/analysis.ts | Added missingPredictors array property to monthly and annual summary interfaces |
| src/app/calculations/analysis-calculations/monthlyAnalysisSummaryDataClass.ts | Implemented checkMissingPredictors method to identify missing predictor variables per month |
| src/app/calculations/analysis-calculations/monthlyAnalysisCalculatedValuesClassSummation.ts | Added logic to aggregate missing predictors across months using lodash's uniq function |
| src/app/calculations/analysis-calculations/annualAnalysisSummaryDataClass.ts | Implemented setMissingPredictors method to aggregate missing predictors for annual summaries |
| src/app/calculations/analysis-calculations/*.ts | Updated toObject methods in summary classes to include missingPredictors in output |
| src/app/shared/shared-analysis/monthly-analysis-summary-table/* | Enhanced table component with getPredictorVariableStatus method and visual indicators for missing data |
| src/app/shared/shared-analysis/annual-analysis-summary-table/* | Enhanced table component with checkPredictorValueStatus method and row highlighting for missing data |
| Various report and analysis component templates | Propagated new input properties (groupSummaries, isAccount, inReport, group) to summary table components |
| *.component.css | Added CSS styling for missing-month-row highlighting and missing-predictor-cell layout |
| package-lock.json | Dependency resolution updates (peer dependency changes) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...d/shared-analysis/annual-analysis-summary-table/annual-analysis-summary-table.component.html
Show resolved
Hide resolved
...d/shared-analysis/annual-analysis-summary-table/annual-analysis-summary-table.component.html
Outdated
Show resolved
Hide resolved
...d/shared-analysis/monthly-analysis-summary-table/monthly-analysis-summary-table.component.ts
Outdated
Show resolved
Hide resolved
...red/shared-analysis/annual-analysis-summary-table/annual-analysis-summary-table.component.ts
Outdated
Show resolved
Hide resolved
src/app/calculations/analysis-calculations/monthlyAnalysisSummaryDataClass.ts
Outdated
Show resolved
Hide resolved
...d/shared-analysis/annual-analysis-summary-table/annual-analysis-summary-table.component.html
Outdated
Show resolved
Hide resolved
...d/shared-analysis/monthly-analysis-summary-table/monthly-analysis-summary-table.component.ts
Show resolved
Hide resolved
...shared-analysis/monthly-analysis-summary-table/monthly-analysis-summary-table.component.html
Outdated
Show resolved
Hide resolved
rmroot
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connects #2131
This pull request enhances the analysis summary data structures and reporting components to track and display missing predictor variables at both the monthly and annual levels. The changes ensure that missing predictors are identified, aggregated, and made available for display in summary tables, improving transparency and data quality diagnostics.
Enhancements to analysis data structures and calculations:
missingPredictorsarray property toMonthlyAnalysisSummaryDataClass,MonthlyAnalysisCalculatedValuesSummation, andAnnualAnalysisSummaryDataClassto track missing predictor variables for each period.MonthlyAnalysisSummaryDataClassto populate themissingPredictorsarray by checking for missing predictor variables in each month.MonthlyAnalysisCalculatedValuesSummationandAnnualAnalysisSummaryDataClassto aggregate missing predictors across months or the year, ensuring unique lists.Propagation of missing predictor information to summary outputs:
MonthlyAnalysisSummaryClass,MonthlyAccountAnalysisClass,MonthlyFacilityAnalysisClass,AnnualAccountAnalysisSummaryClass,AnnualFacilityAnalysisSummaryClass,AnnualGroupAnalysisSummaryClass) to includemissingPredictorsin their output objects, making this information available for display.toObject()methods to return the newmissingPredictorsproperty.UI and reporting updates:
[isAccount],[inReport], and[groupSummaries]to summary table components in various report and analysis result templates, preparing the UI to display the enhanced summary information.These changes collectively improve the application's ability to surface and report on missing predictor data, supporting better analysis and troubleshooting.