Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connects #542
This pull request adds functionality to display the source type of each meter group in the meter grouping UI, including support for groups with mixed sources. The main changes include the creation and integration of a new pipe to determine the group source, UI updates to show the source as a colored badge, and updates to styles and tests.
Feature: Meter Group Source Display
MeterGroupSourcePipe, which determines the source type for a meter group (returns a specific source or 'Mixed' if the group contains meters with different sources). (src/app/shared/helper-pipes/meter-group-source-pipe.ts)MeterGroupSourcePipein theHelperPipesModuleand updated module declarations, imports, and exports. (src/app/shared/helper-pipes/_helper-pipes.module.ts) [1] [2] [3]MeterGroupSourcePipe. (src/app/shared/helper-pipes/meter-group-source-pipe.spec.ts)UI Enhancements
MeterSourceColorPipe. The badge shows 'Mixed' if the group contains meters from multiple sources. (src/app/shared/shared-meter-content/set-meter-grouping/set-meter-grouping.component.html) [1] [2] [3] [4] [5] [6].largeCSS class to adjust the badge font size. (src/app/shared/shared-meter-content/set-meter-grouping/set-meter-grouping.component.css)Pipe Enhancement
MeterSourceColorPipeto handle the new 'Mixed' source type, assigning it a specific color. (src/app/shared/helper-pipes/meter-source-color.pipe.ts)