Issue 2118 - add additional fields and validation to user defined models#2181
Merged
Issue 2118 - add additional fields and validation to user defined models#2181
Conversation
rmroot
requested changes
Dec 12, 2025
Member
rmroot
left a comment
There was a problem hiding this comment.
Couple things:
- We need to check on how this effects calculations. There is a model year baseline adjustment that happens based on the model year. I will talk to Kristina and Chris.
- I'm not sure it's working properly, I went to West energy analysis and switched the ProductionElectricity to User Defined Model and set Model Start Year to 2020 and didn't get an error of it being after Model End Year
- The tables for monthly and annual analysis that show a icon for the model year. Those need to be updated with the changes. Right now it's just a IF statement on the year, I'd recommend using a pipe.
…ummary table. Enable/disable tabs
rmroot
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connects #2118
This pull request introduces significant enhancements to the regression model selection workflow, focusing on improved date range handling, validation, and error messaging for user-defined models. The changes add new properties to track both start and end dates for regression models, implement comprehensive validation to ensure data completeness and correct date ranges, and update the UI to provide clear feedback to users.
Key changes include:
Regression Model Date Range Enhancements
AnalysisGroupand related interfaces to support both start and end months and years for regression models, enabling more flexible and accurate date range selection. (src/app/models/analysis.ts,src/app/models/idbModels/analysisItem.ts)Validation and Error Handling
RegressionModelMenuComponentto check for:GroupErrorsand validation service to support new date fields.User Interface Improvements
Data Filtering and Model Inspection
Error State Propagation
These changes collectively improve the accuracy, reliability, and user experience of the regression model selection and validation process.