Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connects #1751
This pull request adds new functionality to support updating weather predictor data after importing account data, along with UI improvements to guide users through this process. The most important changes are the addition of new methods and UI elements to facilitate updating weather predictors, as well as some supporting service and logic updates.
Weather Predictor Update Workflow
@Input() fileReferencetoUpdateWeatherPredictorsModalComponentand updated its logic to use facilities from the imported file, enabling facility-specific weather predictor updates after data import. [1] [2] [3] [4]updateWeatherPredictorData(fileReference)toUploadDataServicethat calculates date ranges for each facility and calls the weather predictor management service to update predictors. [1] [2] [3]UI Enhancements
submit-import-data.component.html) to show a success message and buttons for updating weather predictors or uploading another file after successful data import. The weather predictor update modal is conditionally displayed. [1] [2]SubmitImportDataComponentto manage the display of the weather predictor modal and track submission state, as well as logic to check for weather predictors and handle the new workflow. [1] [2] [3] [4]Weather Predictor Calculation Improvements
WeatherPredictorManagementServiceto also flag predictors when no degree days are available, increasing data integrity.