Issue 2154 - functionality to check the differences in the existing and imported predictor readings#2160
Merged
Issue 2154 - functionality to check the differences in the existing and imported predictor readings#2160
Conversation
…rted prectictor readings
rmroot
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connects #2154
This pull request adds functionality to compare imported predictor readings against existing data, allowing users to view differences in a modal dialog. It introduces new UI elements for displaying comparison results, including sortable tables and tooltips, and improves data handling to prevent unintended mutations. The changes are grouped into enhancements to comparison logic, UI updates, and code/data improvements.
Comparison logic enhancements:
comparePredictorReadings()method and supporting state toProcessPredictorReadingsComponentto compute and store differences between imported and existing predictor readings by predictor and facility, including difference and percentage difference calculations.PredictorReadingComparisoninterface to structure comparison data for display.UI updates:
Code/data improvements:
UploadDataV3Serviceto clone existing predictor data before modifying, preventing unintended mutations to original data objects.