Skip to content

Issue 2154 - functionality to check the differences in the existing and imported predictor readings#2160

Merged
rmroot merged 1 commit intodevelopfrom
issue-2154
Nov 24, 2025
Merged

Issue 2154 - functionality to check the differences in the existing and imported predictor readings#2160
rmroot merged 1 commit intodevelopfrom
issue-2154

Conversation

@jamlokim
Copy link
Copy Markdown
Contributor

connects #2154

This pull request adds functionality to compare imported predictor readings against existing data, allowing users to view differences in a modal dialog. It introduces new UI elements for displaying comparison results, including sortable tables and tooltips, and improves data handling to prevent unintended mutations. The changes are grouped into enhancements to comparison logic, UI updates, and code/data improvements.

Comparison logic enhancements:

  • Added comparePredictorReadings() method and supporting state to ProcessPredictorReadingsComponent to compute and store differences between imported and existing predictor readings by predictor and facility, including difference and percentage difference calculations.
  • Introduced PredictorReadingComparison interface to structure comparison data for display.

UI updates:

  • Added a modal popup to display a sortable table of predictor reading differences, with controls for opening/closing and ordering by various fields.
  • Updated the predictor readings summary table to show an eye icon for predictors with differences, allowing users to open the modal for detailed comparison.
  • Replaced static "Existing Predictors Entries" header with a tooltip-enabled label for improved user guidance.

Code/data improvements:

  • Modified data import logic in UploadDataV3Service to clone existing predictor data before modifying, preventing unintended mutations to original data objects.

@jamlokim jamlokim requested a review from rmroot November 20, 2025 21:33
@rmroot rmroot merged commit 59f3517 into develop Nov 24, 2025
3 checks passed
@jamlokim jamlokim deleted the issue-2154 branch January 12, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants