Issue 2144: updated date parsing in template v3 upload logic#2145
Merged
Issue 2144: updated date parsing in template v3 upload logic#2145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connects #2144
This pull request improves how read dates are parsed during data import, ensuring consistent handling of different date formats. The main change is the introduction of a new
getTemplateReadDatemethod inUploadDataV3Service, which standardizes date parsing across multiple import scenarios. Additionally, a minor fix was made inAccountReportsServiceto prevent errors when the selected report isnull.Date parsing improvements:
getTemplateReadDatemethod toUploadDataV3Serviceto correctly parse dates inYYYY-MM-DDformat and fallback to the defaultDateconstructor for other formats. This change helps handle template dates more reliably.new Date(readDateStr)calls withgetTemplateReadDate(readDateStr)throughoutUploadDataV3Service, ensuring consistent date parsing for utility meter and facility data imports. [1] [2] [3] [4] [5] [6] [7]Error prevention:
AccountReportsServiceto only validate and compare reports when a report is actually selected, preventing potential errors when the report isnull.