Issue 2074 - logic for displaying the eye icon changed#2133
Merged
Conversation
rmroot
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connects #2074
This pull request refactors the
MeterDataSummaryTableComponentto optimize how meter reading differences are managed and displayed. The main improvement is the introduction of areadingDifferencesMapfor efficient access to comparison results, which streamlines modal interactions and UI conditionals. Additionally, some unused UI elements were removed for clarity.Data handling and performance improvements:
readingDifferencesMapobject to cache meter reading differences for each meter, computed once during initialization with the newcomputeReadingChanges()method. This avoids redundant calculations and simplifies access to differences when opening the modal.UI logic and cleanup:
readingDifferencesMapinstead of the previousnewEntriescheck, ensuring more accurate UI feedback.Modal interaction:
readingDifferencesMap, further simplifying the code and improving performance.