Conversation
rmroot
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connects #974
This pull request introduces improved validation logic for report year selection in both account and facility report components, ensuring that users cannot select a report year earlier than the baseline year for certain report types. It also adds new error messaging to guide users and updates the validation flow for report setup forms.
Account Report Year Validation and Error Messaging:
account-report-setup.component.htmlto inform users when the report year is earlier than the baseline year.compareBaselineYearToReportYearErrorobservable inAccountReportsServiceand integrated its subscription into bothAccountReportSetupComponentandAccountReportsBannerComponentto trigger error messages and validation updates.compareBaselineYearToReportYearmethod inAccountReportsServiceto set the error state when the report year is less than the baseline year for 'performance' and 'betterClimate' report types.Account Report Setup Validation Logic:
AccountReportsBannerComponentto consider the new year comparison error for 'performance' and 'betterClimate' reports, preventing form submission when the error is present.Facility Report Year Validation:
FacilityReportsServicevalidation to handle 'emissionFactors' reports, ensuring the start year is not later than the end year and providing appropriate error messaging.