Conversation
rmroot
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connects #878
This pull request updates the phone number input handling in the
GeneralInformationFormComponentto improve user experience and data consistency, especially for US phone numbers. The main changes include adding phone number formatting logic and adjusting input constraints.Phone input improvements:
formatPhonemethod ingeneral-information-form.component.tsto automatically format US phone numbers as the user types, inserting dashes after the third and sixth digits and restricting the length to 12 characters.general-information-form.component.htmlto use the newformatPhonemethod on input events, and increased the maximum allowed length from 10 to 12 characters.