Issue 1214 - backward compatibility logic added, years displayed in dropdown changed#2117
Merged
Issue 1214 - backward compatibility logic added, years displayed in dropdown changed#2117
Conversation
rmroot
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connects #1214
This pull request refactors the year selection logic in the
RegressionModelMenuComponentand introduces a safeguard for regression model start month initialization in the database update service. The main focus is on removing the dependency onCalanderizationServicefor year options and calculating them directly from facility meter data, along with ensuring a default value for regression model start month.Refactoring year selection logic:
CalanderizationServicefromregression-model-menu.component.ts, and replaced its year options logic with a new methodsetYearsthat calculates year options based on the earliest and latest meter readings infacilityMeterData.facilityMeterDatato store meter data, which is used in the newsetYearsmethod.Database update safeguard:
update-db-entry.service.ts, added logic to set a default value (0) forregressionModelStartMonthin regression analysis groups where the value is undefined and the model is not user-defined, ensuring consistent initialization.