Issue 2055: Add warning for report year selection in facility analysis setup#2102
Merged
Issue 2055: Add warning for report year selection in facility analysis setup#2102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connects #2055
This pull request adds a warning and supporting logic to notify users when a facility lacks a full year of data for the selected report year in the analysis setup. The goal is to guide users to use the "Savings Report" feature for mid-year progress instead of running an analysis with incomplete data.
User interface improvements:
analysis-setup.component.htmlthat displays when the selected report year does not have 12 months of data, including a link to the "Savings Report" for mid-year progress.Component logic and behavior:
showReportYearWarningproperty and implemented thesetReportYearWarningmethod inanalysis-setup.component.tsto determine when to show the warning based on data completeness for the selected report year. [1] [2] [3]changeReportYearmethod to invokesetReportYearWarningwhenever the report year changes, ensuring the warning is shown or hidden appropriately.goToSavingsReportmethod to navigate users to the "Savings Report" page when the link in the warning is clicked.Code maintenance:
analysis-setup.component.tsto includeActivatedRoutefor improved navigation handling.