Issue 2056 - added pagination to monthly tables. added copy table button to tables#2070
Merged
Issue 2056 - added pagination to monthly tables. added copy table button to tables#2070
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances table functionality in the savings report components by adding pagination controls and removing unnecessary input properties. The changes improve user experience by allowing users to control the number of items displayed per page in monthly analysis tables.
- Added proper subscription management to the table items dropdown component to prevent memory leaks
- Integrated pagination dropdown controls into monthly analysis sections of both account and facility savings reports
- Removed the unnecessary
inReportinput property from all summary table components to streamline the API
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| table-items-dropdown.component.ts | Added proper subscription management with ngOnDestroy lifecycle hook |
| facility-savings-report-results.component.ts | Removed unused import for SavingsFacilityReportSettings |
| facility-savings-report-results.component.html | Added pagination dropdowns and removed inReport input from table components |
| account-savings-report.component.html | Added pagination dropdown and removed inReport input from table components |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
rmroot
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connects #2056
This pull request updates the account and facility savings report components to improve table pagination controls and streamline input properties for summary tables. The most significant changes are the removal of the unnecessary
inReportinput from summary table components and the addition of a new dropdown component for selecting items per page, with improved subscription management.Pagination and UI improvements:
app-table-items-dropdowncomponent to the monthly analysis summary sections in bothaccount-savings-report.component.htmlandfacility-savings-report-results.component.html, allowing users to select the number of items per page.