Issue 2019: Use guids instead of int IDs for routing#2022
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a comprehensive migration from integer-based IDs to GUID-based routing throughout the application. The primary purpose is to standardize on GUID identifiers for all navigation and URL paths, replacing integer ID references with GUID equivalents.
Key changes include:
- Updated all routing URLs to use GUID properties instead of integer ID properties for facilities, meters, and other entities
- Modified parameter parsing logic to handle string GUIDs instead of integer IDs
- Updated analytics service to properly handle GUID patterns in URL cleanup
Reviewed Changes
Copilot reviewed 42 out of 42 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Multiple component files | Updated router navigation calls to use .guid instead of .id properties |
| HTML template files | Changed routerLink attributes to reference GUID properties |
| Parameter parsing components | Modified to parse string GUIDs instead of integer IDs |
| Analytics service | Updated URL pattern matching to handle GUID format |
Comments suppressed due to low confidence (1)
src/app/shared/shared-meter-content/meter-data/meter-data-table/meter-data-table.component.ts:59
- This TODO comment about updating for int is now obsolete since the migration to GUIDs is complete. The comment should be removed.
this.paramsSub = this.activatedRoute.parent.params.subscribe(params => {
src/app/shared/shared-meter-content/meter-data/meter-data-table/meter-data-table.component.ts
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connects #2019
updates analytics events to strip guid and cleanup rollup of analytics page views
all navigation uses guid instead of int IDs