Issue 169: fix payback calculation so it isn't negative#173
Merged
Conversation
RLiNREL
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connects #169
This pull request improves the robustness of payback calculations across several report generation functions by ensuring that invalid payback values (such as negative numbers or NaN) are set to zero, in addition to handling Infinity as before. This prevents misleading or erroneous payback results from appearing in reports.
Improvements to payback calculation validation:
getAssessmentReport(assessmentReport.ts) to set payback to zero if the result is Infinity, NaN, or negative. [1] [2]getEnergyOpportunityReport(energyOpportunityReport.ts).getExecutiveSummaryReport(executiveSummaryReport.ts) to include checks for negative and NaN values.ExecutiveSummaryProjectSummaryComponentto ensure payback values are set to zero if they are Infinity, negative, or NaN.