Merged
Conversation
7h30n3
approved these changes
Dec 9, 2024
Member
7h30n3
left a comment
7h30n3
left a comment
There was a problem hiding this comment.
LGTM!
Maybe while you are at it change the wording of @escalatorDurationName.
Member
Author
|
TODO: Improve the case where the user activates the stop watch and then goes to the next page without pressing stop. Solutions:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #130
Initially it was designed to work with minutes as well (see screenshot).
However the stop watch button is mainly used in scenarios with short time periods (up to 2 minutes) so it was simplified to work for seconds only.
Also contains a slight redesign of the general duration input.