Split footway map feature into more detailed features#300
Merged
Robbendebiene merged 5 commits intomasterfrom Dec 9, 2024
Merged
Split footway map feature into more detailed features#300Robbendebiene merged 5 commits intomasterfrom
Robbendebiene merged 5 commits intomasterfrom
Conversation
old: footway new: footway, cycle path and foot and cycle path
Minor fix removing OpenWay from highway=crossing map feature
7h30n3
requested changes
Dec 3, 2024
7h30n3
approved these changes
Dec 3, 2024
Reasoning: There are too many elements that represent a pure cycleway or footway but are tagged with cycleway:surface or footway:surface instead of just surface. (e.g. https://www.openstreetmap.org/way/386759511) Therefore we cannot safely assume if one of the prefixed tags (e.g. cycleway:surface) is set the other (footway:surface) is missing.
7h30n3
approved these changes
Dec 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #298