Merged
Conversation
7h30n3
requested changes
Jul 3, 2024
Member
|
I also think the tag doesn't make much sense for sliding doors. So they should be excluded as well. |
Contributor
Author
Really? One of our examples in the proposal is a sliding door. |
Robbendebiene
requested changes
Jul 10, 2024
Contributor
Author
|
Ready for re-review now, schematic images are to be added later. |
Robbendebiene
requested changes
Jul 11, 2024
Contributor
Author
|
Should be ready for re-review now |
Robbendebiene
requested changes
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds questions regarding the recent
open=proposal.Theese questions are: