Add elevator questions#271

Merged

Robbendebiene merged 43 commits intoOPENER-next:masterfrom

wielandb:elevator-questions

Jul 22, 2024

Contributor

wielandb commented Jul 1, 2024 •

edited

Loading

This PR adds some questions that relate to the recent "Evelator dimensions" proposal.

These questions are:

What shape does this elevator have?
What's the diameter of this elevator?
How tall is the cabin of this elevator?
How wide is the door of this elevator?
How tall is the door of this elevator?

It modifies the questions

How wide is this elevator?
How deep is this elevator?
to only be asked if the elevator has a rectangular shape

It does not ask for any max*:physical=*values as this is currently not possible with this app.

Currently missing:

Example images

wielandb added 3 commits

July 1, 2024 15:22


          Add elevator questions

9069b35


          Add german strings

3fb4f8b


          Remove nonexistent images

397dde5

wielandb marked this pull request as ready for review

July 2, 2024 10:14

7h30n3 requested changes

View reviewed changes

assets/question_catalog/definition.json Outdated Show resolved Hide resolved

assets/question_catalog/locales/en.arb Outdated Show resolved Hide resolved

assets/question_catalog/locales/en.arb Outdated Show resolved Hide resolved

assets/question_catalog/locales/en.arb Outdated Show resolved Hide resolved

assets/question_catalog/locales/de.arb Outdated Show resolved Hide resolved

assets/question_catalog/locales/en.arb Outdated Show resolved Hide resolved

assets/question_catalog/definition.json Outdated Show resolved Hide resolved

assets/question_catalog/locales/en.arb Outdated Show resolved Hide resolved

assets/question_catalog/locales/en.arb Outdated Show resolved Hide resolved

assets/question_catalog/locales/en.arb Outdated Show resolved Hide resolved

Robbendebiene requested changes

View reviewed changes

assets/question_catalog/definition.json Outdated Show resolved Hide resolved

assets/question_catalog/definition.json Outdated Show resolved Hide resolved

assets/question_catalog/definition.json Outdated Show resolved Hide resolved

assets/question_catalog/definition.json Outdated Show resolved Hide resolved

wielandb added 22 commits

July 9, 2024 12:42


          Make !parent a sibling condition to osm_tags

1cc9c1a


          Add comma

f951672


          Add comma

1938fd1


          Add comma

46390aa


          Fix string reference

14a0b0f


          Update min height

f9c2444


          Update min height

eb1c3fc


          Fix wrong tags beeing written

e6ccf6c


          remove unit from strings

d01ccde


          Update strings

5bae3e4


          Update de.arb

45bda99


          Update de.arb

e014988


          Update de.arb

5d0974a


          Update en.arb

a0e7306


          Update en.arb

f9d03e5


          Update en.arb

19278e4


          Update en.arb

d651445


          Increase min diameter

778cd98


          Update en.arb

b1c691e


          Update en.arb

5e85fe4


          Update en.arb

6efc96f


          Use centimeter as units

b2cc89f

Contributor Author

wielandb commented Jul 9, 2024

The JSON validation fails.

I don't really understand what's wrong about

            "max": 4,
            "unit": "@unitCentimeter"
         },
         "constructor": {
            "diameter": ["CONCAT", "$input", "m"]
         }
      },

Robbendebiene requested changes

View reviewed changes

assets/question_catalog/definition.json Outdated Show resolved Hide resolved

assets/question_catalog/locales/de.arb Outdated Show resolved Hide resolved

assets/question_catalog/locales/en.arb Outdated Show resolved Hide resolved

assets/question_catalog/locales/en.arb Outdated Show resolved Hide resolved

assets/question_catalog/locales/en.arb Outdated Show resolved Hide resolved

assets/question_catalog/locales/en.arb Outdated Show resolved Hide resolved

assets/question_catalog/locales/en.arb Outdated Show resolved Hide resolved

wielandb added 10 commits

July 10, 2024 10:23


          Fix missing comma

a7e1826


          Make units actually cm

b188cd6


          Fix breaking typo

95771c0


          Update en.arb

54e82d3


          Update en.arb

783886a


          Update en.arb

63e194b


          Update en.arb

a079e09


          Update en.arb

0b782ff


          Add space before meters

3ff62c9


          Explement shape= question, only ask for rectangular elevators

382494b

Robbendebiene requested changes

View reviewed changes

assets/question_catalog/definition.json Outdated Show resolved Hide resolved

assets/question_catalog/definition.json Outdated Show resolved Hide resolved

assets/question_catalog/definition.json Outdated Show resolved Hide resolved

assets/question_catalog/definition.json Outdated Show resolved Hide resolved

assets/question_catalog/locales/de.arb Outdated Show resolved Hide resolved

assets/question_catalog/locales/de.arb Outdated Show resolved Hide resolved

assets/question_catalog/locales/de.arb Outdated Show resolved Hide resolved

assets/question_catalog/locales/en.arb Outdated Show resolved Hide resolved

wielandb added 3 commits

July 15, 2024 09:43


          Change minmax values

acc0eea


          Add a comment

a253a5f


          Update translations

7e4f66c

wielandb requested review from 7h30n3 and Robbendebiene

July 15, 2024 07:50

Robbendebiene requested changes

View reviewed changes

assets/question_catalog/definition.json Outdated Show resolved Hide resolved

assets/question_catalog/definition.json Outdated Show resolved Hide resolved

assets/question_catalog/definition.json Outdated Show resolved Hide resolved

wielandb added 2 commits

July 18, 2024 10:52


          Tighten conditions for elevator door width

ec24d09


          Expand door:* conditions

56b9922

wielandb requested a review from Robbendebiene

July 18, 2024 09:04

Robbendebiene requested changes

View reviewed changes

Member

Robbendebiene left a comment

Move all new elevator questions right below the elevator width/length questions.

assets/question_catalog/definition.json Outdated Show resolved Hide resolved

assets/question_catalog/definition.json Outdated Show resolved Hide resolved

wielandb and others added 3 commits

July 22, 2024 10:19


          Update assets/question_catalog/definition.json

cb72202

Co-authored-by: Robin Thomas <[email protected]>


          Update assets/question_catalog/definition.json

386671e

Co-authored-by: Robin Thomas <[email protected]>


          Move elevator questions to other elevator questions

fe58e7f

wielandb requested a review from Robbendebiene

July 22, 2024 08:30

Robbendebiene merged commit 5e3b3b1 into OPENER-next:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet