Merged
Conversation
Replaces old stop area query api, stop class and stop area generator. Internally changes stop areas from circles to bounding boxes.
f30aad1 to
9a2cc7c
Compare
81fc82f to
381a747
Compare
7h30n3
approved these changes
May 24, 2024
| static String _buildQuery (int mergeRadius) => | ||
| // get all platforms | ||
| 'nwr[public_transport=platform]->.remaining_platforms;' | ||
| // return all bboxes of stop aras and platforms not part of stop areas |
Member
There was a problem hiding this comment.
Suggested change
| // return all bboxes of stop aras and platforms not part of stop areas | |
| // return all bboxes of stop areas and platforms not part of stop areas |
381a747 to
bae32d5
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed:
Decisions
It was decided against additionally using
public_transport=stop_areainside the query.While it has benefits like:
The downside is that in reality stop areas overlap or are incomplete (wherefore a new stop area is created through grouping). This can lead to overlapping stop areas (bboxes) thus having multiple requests for the same region + overlapping loading indicators.
Ideal solution would be a merging/grouping by geometry of the existing stop areas wit the remaining platforms.
Query with stop areas (faster but overlapping bboxes):
Query with stop areas, but merge stop areas with remaining platforms and other stop areas (sometimes slightly better bboxes, not faster, but for wrong stop areas we get large bboxes https://www.openstreetmap.org/relation/7646731/history/4)