Gallery viewer for additional information#238
Gallery viewer for additional information#238Robbendebiene merged 7 commits intoOPENER-next:masterfrom
Conversation
yulieth9109
force-pushed
the
gallery_viewer
branch
4 times, most recently
from
2278924 to
d1e1b85
Compare
yulieth9109
force-pushed
the
gallery_viewer
branch
from
d1e1b85 to
fb3ce12
Compare
There was a problem hiding this comment.
One thing that is harder to solve is that the hero transition image is overlaying the arrows that are fading in. When the image gets removed the arrows suddenly appear.
This can only be solved with https://api.flutter.dev/flutter/widgets/Hero/flightShuttleBuilder.html but please do this last after everything else is done and in a separate commit.
|
What also doesn't work well is zooming and panning in the image. Most of the time the PageView gesture wins while I think the opposite would be better (InterActiveViewer wins, and only looses when panning isn't possible any more). Just try zooming in via pinch gesture. |
|
This currently suffers from a problem where scaling and dragging interfere. For reference: |
Robbendebiene
left a comment
Robbendebiene
left a comment
There was a problem hiding this comment.
hasPrevious, hasNext have become obsolete and can be removed
Robbendebiene
left a comment
Robbendebiene
left a comment
There was a problem hiding this comment.
LGTM
Minor problem left: Navigation arrows are shortly covered by the animating image wherefore they appear to flicker at the start.
2 participants
No description provided.