Skip to content

Add stairs tactile paving question#190

Merged
7h30n3 merged 9 commits intoOPENER-next:masterfrom
wielandb:stairs-tactile-paving
Jul 24, 2023
Merged

Add stairs tactile paving question#190
7h30n3 merged 9 commits intoOPENER-next:masterfrom
wielandb:stairs-tactile-paving

Conversation

@wielandb
Copy link
Copy Markdown
Contributor

@wielandb wielandb commented Jul 11, 2023

This PR adds a question that asks for tactile paving on steps.

It uses the answers from https://wiki.openstreetmap.org/wiki/Key:tactile_paving

@7h30n3
Copy link
Copy Markdown
Member

7h30n3 commented Jul 19, 2023

LGTM.
If images for the particular answers are added this PR can be merged.

@wielandb
Copy link
Copy Markdown
Contributor Author

wielandb commented Jul 20, 2023

Are the images okay? If the motive is good but the lighting is deemed insufficient, I can retake the pictures in better lighting conditions.

@wielandb wielandb changed the title Add stairs tactile paving questions Add stairs tactile paving question Jul 20, 2023
@7h30n3
Copy link
Copy Markdown
Member

7h30n3 commented Jul 20, 2023

Are the images okay? If the motive is good but the lighting is deemed insufficient, I can retake the pictures in better lighting conditions.

The images should be named as the tag they describe, so for example:
steps_tactile_paving_both.jpg > steps_tactile_paving_yes.jpg

The following images needs to be replaced:
steps_tacticle_paving_top.jpg > Has some weird vignette and clearly shows tactile paving at the bottom of the stairs. An image like that could be used for the value yes.

steps_tacticle_paving_both.jpg > The eyes have trouble finding a fix point in the collage. So don't merge images like this.

7h30n3
7h30n3 reviewed Jul 20, 2023
View reviewed changes
7h30n3
7h30n3 reviewed Jul 20, 2023
View reviewed changes
@wielandb
Copy link
Copy Markdown
Contributor Author

wielandb commented Jul 20, 2023

The following images needs to be replaced: steps_tacticle_paving_top.jpg > Has some weird vignette and clearly shows tactile paving at the bottom of the stairs. An image like that could be used for the value yes.
steps_tacticle_paving_both.jpg > The eyes have trouble finding a fix point in the collage. So don't merge images like this.

Replaced yes, partial, incorrect with new ones.

@7h30n3
Copy link
Copy Markdown
Member

7h30n3 commented Jul 21, 2023

The following images needs to be replaced: steps_tacticle_paving_top.jpg > Has some weird vignette and clearly shows tactile paving at the bottom of the stairs. An image like that could be used for the value yes.
steps_tacticle_paving_both.jpg > The eyes have trouble finding a fix point in the collage. So don't merge images like this.

Replaced yes, partial, incorrect with new ones.

Thanks. Could you also provide the original images.

@wielandb
Copy link
Copy Markdown
Contributor Author

wielandb commented Jul 21, 2023

All provided ✔️

@7h30n3 7h30n3 merged commit f798d07 into OPENER-next:master Jul 24, 2023
yulieth9109 pushed a commit to yulieth9109/OpenStop that referenced this pull request Aug 31, 2023
@wielandb @7h30n3 @yulieth9109
Add stairs tactile paving question (OPENER-next#190)
0050f2e 
* Add stairs tactile paving questions

* Add images

---------

Co-authored-by: René Apitzsch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@7h30n3 7h30n3 7h30n3 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wielandb @7h30n3