Implementation of localizations for the question catalog#189
Merged
Robbendebiene merged 11 commits intoOPENER-next:masterfrom Sep 1, 2023
Merged
Implementation of localizations for the question catalog#189Robbendebiene merged 11 commits intoOPENER-next:masterfrom
Robbendebiene merged 11 commits intoOPENER-next:masterfrom
Conversation
yulieth9109
force-pushed
the
stop-area-discovery
branch
6 times, most recently
from
dde24a2 to
aa427c9
Compare
yulieth9109
force-pushed
the
stop-area-discovery
branch
from
810f11f to
2a12c28
Compare
yulieth9109
force-pushed
the
stop-area-discovery
branch
from
dd1a47a to
cc69b61
Compare
Robbendebiene
requested changes
Aug 28, 2023
Member
Robbendebiene
left a comment
Robbendebiene
left a comment
There was a problem hiding this comment.
- This can be removed in this PR.
- Replace
question_catalog.jsonwithdefinition.jsonhere and adjust this path. - Address the code validation checks: https://github.com/OPENER-next/OpenStop/actions/runs/5974992411/job/16210125991
yulieth9109
force-pushed
the
stop-area-discovery
branch
3 times, most recently
from
c5ebeed to
e83fcbf
Compare
Catalog reader with WidgetsBindingObserver to update catalog when device locate changes
Update of testing classes to include the changes to read the question catalog
yulieth9109
force-pushed
the
stop-area-discovery
branch
from
e83fcbf to
7236f11
Compare
- Implement keynames for the translation of the questions. - Include new questions. - Fixing indentation
yulieth9109
force-pushed
the
stop-area-discovery
branch
from
7236f11 to
b65cf52
Compare
yulieth9109
force-pushed
the
stop-area-discovery
branch
5 times, most recently
from
ae8d1af to
b65cf52
Compare
yulieth9109
force-pushed
the
stop-area-discovery
branch
2 times, most recently
from
d3f3d3f to
a4e3714
Compare
Contributor
Author
|
The changes were implemented |
yulieth9109
force-pushed
the
stop-area-discovery
branch
from
a925988 to
0315fe4
Compare
- Update question catalog schema - Fixing validation errors - Update validation JSON - Implementing formatting comments - Move class QuestionCatalogChange to the QuestionCatalogReader
yulieth9109
force-pushed
the
stop-area-discovery
branch
from
0315fe4 to
d9e95ea
Compare
Robbendebiene
approved these changes
Sep 1, 2023
Member
Robbendebiene
left a comment
Robbendebiene
left a comment
There was a problem hiding this comment.
Thanks, this can finally be merged 🥳
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.