Skip to content

Add mode-of-transport question#187

Merged
7h30n3 merged 20 commits intoOPENER-next:masterfrom
wielandb:mode-of-transport-question
Jul 20, 2023
Merged

Add mode-of-transport question#187
7h30n3 merged 20 commits intoOPENER-next:masterfrom
wielandb:mode-of-transport-question

Conversation

@wielandb
Copy link
Copy Markdown
Contributor

@wielandb wielandb commented Jul 2, 2023

This PR adds a question that asks what kind of vehicles stop at a platform. It only asks the question if there are no indicators whatsoever about what vehicles stop at the platform.

@wielandb
Copy link
Copy Markdown
Contributor Author

wielandb commented Jul 6, 2023

I added conditions so that the three cases where the question is asked are:

  • public_transport=platform without any vehicles given
  • railway=platform without any vehicles given
  • highway=bus_stop without any vehicles given, who also does not have public_transport=platform as a parent

@wielandb wielandb requested review from 7h30n3 and Robbendebiene July 18, 2023 11:36
@7h30n3
Copy link
Copy Markdown
Member

7h30n3 commented Jul 19, 2023

Thanks for adding images.

@wielandb
Copy link
Copy Markdown
Contributor Author

  • The shortest side of an image needs to be (at least) 2000px and the file size usually should be between 1 and 2 MB, please take this into consideration.

Done. I was orienting myself at the suggestions made here
I updated the pictures where possible so that the shortest side is always at least 2000px. I choose quality settings that made every image (where possible) approx. 1.5 Mb in size.

  • If you need to crop an image please keep the aspect ratio of the original (often 5:4) or use 1:1

Changed. I thought it would be more important to have a consistent aspect ratio between all images of a question than to not change it in regards to the original.

@wielandb
Copy link
Copy Markdown
Contributor Author

Should be ready for re-review.

@7h30n3
Copy link
Copy Markdown
Member

7h30n3 commented Jul 20, 2023

Thanks for updating the PR.

  • The shortest side of an image needs to be (at least) 2000px and the file size usually should be between 1 and 2 MB, please take this into consideration.

Done. I was orienting myself at the suggestions made here I updated the pictures where possible so that the shortest side is always at least 2000px. I choose quality settings that made every image (where possible) approx. 1.5 Mb in size.

Sorry, my bad. All images I contribute had a side length of 2000px. So the "at least" in my first comment was somewhat contradicting to your reference.

  • If you need to crop an image please keep the aspect ratio of the original (often 5:4) or use 1:1

Changed. I thought it would be more important to have a consistent aspect ratio between all images of a question than to not change it in regards to the original.

That's right, but why choosing 16 by 9 and not keeping the original ones. As most image sensors have a very similar aspect ratio anyway.

@7h30n3 7h30n3 merged commit 72e95b2 into OPENER-next:master Jul 20, 2023
@wielandb wielandb deleted the mode-of-transport-question branch July 20, 2023 11:27
yulieth9109 pushed a commit to yulieth9109/OpenStop that referenced this pull request Aug 31, 2023
* Add MOT question

* Add images

---------

Co-authored-by: Robin Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants