Replacement Strings with key names#175
Merged
Robbendebiene merged 8 commits intoOPENER-next:stop-area-discoveryfrom Jun 20, 2023
Merged
Replacement Strings with key names#175Robbendebiene merged 8 commits intoOPENER-next:stop-area-discoveryfrom
Robbendebiene merged 8 commits intoOPENER-next:stop-area-discoveryfrom
Conversation
Robbendebiene
requested changes
Jun 9, 2023
Member
Robbendebiene
left a comment
Robbendebiene
left a comment
There was a problem hiding this comment.
I'm not sure if it is valid, but if I would remove the "format" annotations in the arb files. For example here:
"@numberInputValidationErrorMax": {
"placeholders": {
"nameString": {
"type": "String"
},
"max": {
"type": "num",
"format": "compact"
}
}
},
Because we just want to show the plain number and not some form of short version.
Robbendebiene
requested changes
Jun 12, 2023
Robbendebiene
requested changes
Jun 16, 2023
lib/l10n/app_de.arb
Outdated
Comment on lines
+124
to
+125
| "questionnaireSummaryDedicatedMessage": "Danke {userName}für deine Antworten.\nBitte prüfe sie vor dem Hochladen nochmal.", | ||
| "@questionnaireSummaryDedicatedMessage": {}, |
Member
There was a problem hiding this comment.
Please add a space after {userName}
Robbendebiene
approved these changes
Jun 20, 2023
yulieth9109
added a commit
to yulieth9109/OpenStop
that referenced
this pull request
Aug 31, 2023
Co-authored-by: Robin Thomas <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains the modifications made to all the different classes to implement the internationalization keys that allow the App's translations.