Skip to content

Rework stop area and element discovery#172

Merged
Robbendebiene merged 63 commits intomasterfrom
stop-area-discovery
Jun 28, 2023
Merged

Rework stop area and element discovery#172
Robbendebiene merged 63 commits intomasterfrom
stop-area-discovery

Conversation

@Robbendebiene
Copy link
Copy Markdown
Member

@Robbendebiene Robbendebiene commented May 26, 2023

This PR changes the way how stop areas and elements are discovered.
The elements of stop areas are now automatically loaded when becoming visible in the camera view port.
Additionally stop areas are no longer displayed as circles. Instead there is an overview mode that displays a dot per stop area and colors it to represent whether it is unloaded (gray), loaded and complete (green) or loaded and incomplete (red).

To achieve the desired goal some long planned re-factoring had to be done. That's why this is such an irresponsible massive PR.

Major improvements are:

  • better performance due to the movement of basically all business logic code to a separate thread
  • improved code separation especially for widgets/screens which previously had to contain some logic because providers couldn't access each other

Minor ToDos/Bugs:

Other changes:

  • websites from about or help screens do now open in the app window (can be reverted if desireable)
  • stop area query window has been reduced

@7h30n3
Copy link
Copy Markdown
Member

7h30n3 commented Jun 28, 2023

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants