Rework stop area and element discovery#172
Merged
Robbendebiene merged 63 commits intomasterfrom Jun 28, 2023
Merged
Conversation
There already exists a "distinct" method for streams.
Co-authored-by: Robin Thomas <[email protected]>
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the way how stop areas and elements are discovered.
The elements of stop areas are now automatically loaded when becoming visible in the camera view port.
Additionally stop areas are no longer displayed as circles. Instead there is an overview mode that displays a dot per stop area and colors it to represent whether it is unloaded (gray), loaded and complete (green) or loaded and incomplete (red).
To achieve the desired goal some long planned re-factoring had to be done. That's why this is such an irresponsible massive PR.
Major improvements are:
Minor ToDos/Bugs:
improve "completed marker" show animation and or style- change laterOther changes: