Internationalization and Localization - Part 1#171
Merged
7h30n3 merged 10 commits intoOPENER-next:masterfrom Jun 6, 2023
Merged
Internationalization and Localization - Part 1#1717h30n3 merged 10 commits intoOPENER-next:masterfrom
7h30n3 merged 10 commits intoOPENER-next:masterfrom
Conversation
Include int package Generate keys arb file
7h30n3
changed the title
7h30n3
reviewed
May 31, 2023
Member
|
All keys should be English, not a mix between English and German like |
Member
|
Numbering keys should be avoided as it doesn't give the appropriate context, where and how the key is used. |
7h30n3
reviewed
May 31, 2023
Update key names to provide a better context of where will it be used
Robbendebiene
requested changes
Jun 1, 2023
a-andre
reviewed
Jun 1, 2023
Contributor
There was a problem hiding this comment.
IMO dependency updates should be done in another pull request.
Update of key Names according to last comments
yulieth9109
added a commit
to yulieth9109/OpenStop
that referenced
this pull request
Aug 31, 2023
* Update main.dart * Include intl package * Generate keys arb file --------- Co-authored-by: René Apitzsch <[email protected]> Co-authored-by: Robin Thomas <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull is to Include the internationalization package and the
Generated arb files with the keys of the text translated.