Skip to content

Replace nvbw images with CC0 images#168

Merged
7h30n3 merged 51 commits intoOPENER-next:masterfrom
wielandb:image-replacements
Jun 5, 2023
Merged

Replace nvbw images with CC0 images#168
7h30n3 merged 51 commits intoOPENER-next:masterfrom
wielandb:image-replacements

Conversation

@wielandb
Copy link
Copy Markdown
Contributor

This PR will replace all images in the directory /dependencies/nvbw_open_data/images with images that I took myself and put under the CC0 license.

@wielandb
Copy link
Copy Markdown
Contributor Author

At this point, 18 images remain to be replaced.

@wielandb
Copy link
Copy Markdown
Contributor Author

At this point, 17 images remain to be replaced

@wielandb
Copy link
Copy Markdown
Contributor Author

At this point, 4 images remain to be replaced.

Copy link
Copy Markdown
Member

@Robbendebiene Robbendebiene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please change all image names to a meaningful name like: "parking_surface" "parking_wheelchair_1".
  • Generally reduce the saturation of the images.
  • Ensure minimal resolution of 1000x1000 and a maximal resolution of 2000x2000

@wielandb
Copy link
Copy Markdown
Contributor Author

wielandb commented May 9, 2023

  • Ensure minimal resolution of 1000x1000 and a maximal resolution of 2000x2000

At the moment, the following images violate this rule:

  • approach_aid_no.jpg (too big!)
  • automatic_door_button.jpg (too big!)
  • disabled_parking_1.jpg (too small!)
  • disabled_parking_2.jpg (too small!)
  • disabled_parking_3.jpg (too small!)
  • handrail_2.jpg (too small!)
  • handrail_tactile_writing_1.jpg (too big!)
  • handrail_tactile_writing_2.jpg (too big!)
  • kerb_flush.jpg (too big!)

@7h30n3
Copy link
Copy Markdown
Member

7h30n3 commented May 26, 2023

The only two things missing are a new image for streetside parking and checking if all images are numbered correctly.

@wielandb
Copy link
Copy Markdown
Contributor Author

wielandb commented Jun 2, 2023

Should be ready for final review now. :)

@wielandb wielandb marked this pull request as ready for review June 3, 2023 13:07
@wielandb wielandb requested a review from Robbendebiene June 3, 2023 13:07
@7h30n3 7h30n3 merged commit 87d3fe8 into OPENER-next:master Jun 5, 2023
yulieth9109 pushed a commit to yulieth9109/OpenStop that referenced this pull request Aug 31, 2023
* Initial Image replacements

* Remove exif data from all images in questions folder

* Give the question images more descriptive file names

* Add png versions of traffic signs to two questions

* Update question catalog with new filenames

* Remove nvbw images

* Remove dependency from pubspec

---------

Co-authored-by: René Apitzsch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants