Skip to content

Clarify description for automatic door question#164

Closed
FloEdelmann wants to merge 2 commits intoOPENER-next:masterfrom
FloEdelmann:patch-3
Closed

Clarify description for automatic door question#164
FloEdelmann wants to merge 2 commits intoOPENER-next:masterfrom
FloEdelmann:patch-3

Conversation

@FloEdelmann
Copy link
Copy Markdown
Contributor

No description provided.

@FloEdelmann FloEdelmann changed the title Clarify wording for automatic door question Clarify description for automatic door question Apr 20, 2023
@7h30n3
Copy link
Copy Markdown
Member

7h30n3 commented Apr 21, 2023

Thank you for the contribution.
If you could just remove the "ggf.". I think the "könnte" (could) already describes the button press as optional.

@Robbendebiene
Copy link
Copy Markdown
Member

Robbendebiene commented Apr 21, 2023

What do you think about changing it to: "Bei der automatischen Öffnung wird die Tür von einer Mechanik geöffnet. Diese kann durch einen Sensor oder Taster ausgelöst werden."

@7h30n3
Copy link
Copy Markdown
Member

7h30n3 commented Apr 21, 2023

What do you think about changing it to: "Bei der automatischen Öffnung wird die Tür von einer Mechanik geöffnet. Diese kann durch einen Sensor oder Taster ausgelöst werden."

That's even better 👍

@FloEdelmann
Copy link
Copy Markdown
Contributor Author

That would technically not be correct for the revolving door, which does not need any trigger at all.

@Robbendebiene
Copy link
Copy Markdown
Member

That would technically not be correct for the revolving door, which does not need any trigger at all.

Good point. The continuous value never felt like a good fit for a broad door question. So maybe we could have a more radical change and add extra questions for the revolving door:

  1. if door=revolving we ask whether it turns automatically
  2. if door=revolving && automatic_door=yes we ask whether it turns continuously, on button press or on motion sensor.

Then for every other door type (where continuously doesn't make sense) we only ask for "on button press" and "on motion sensor".
Maybe we should also rephrase the question from "is it an automatic door" to "can it be opened automatically" since some doors can be opened by button and by hand.

7h30n3 added a commit that referenced this pull request Jul 4, 2023
* Differentiate between revovling doors and other types regarding automatic opening
* Split automatic_door question for revolving doors and others

Makes #164 obsolete.
@Robbendebiene
Copy link
Copy Markdown
Member

This has been resolved by #186

@FloEdelmann FloEdelmann deleted the patch-3 branch July 4, 2023 08:24
yulieth9109 pushed a commit to yulieth9109/OpenStop that referenced this pull request Aug 31, 2023
* Differentiate between revovling doors and other types regarding automatic opening
* Split automatic_door question for revolving doors and others

Makes OPENER-next#164 obsolete.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants