Prune extra decoded children that should stay on the type definition only. by mrsuciu · Pull Request #3843 · OPCFoundation/UA-.NETStandard

mrsuciu · 2026-06-04T15:07:55Z

Keep the generated children that belong on instances, and prune the extra decoded children that should stay on the type definition only, such as Optional/Mandatory placeholders and ones that do not have Mandatory/Optional ModellingRules.

Description

Currently child nodes that are type definition detailes such as ones that do not have Mandatory/Optional ModellingRules are instantiated in the runtime instance of such type definitions. This PR proposes to correct this behaviour during NodeState creation as an alternative from it being fixed by the ModelCompiler.

Related Issues

Fixes ProgramStateMachineState has wrong InitializationString and possible many other classes also #3770

Checklist

Put an x in the boxes that apply. You can complete these step by step after opening the PR.

I have signed the CLA and read the CONTRIBUTING doc.
I have added tests that prove my fix is effective or that my feature works and increased code coverage.
I have added all necessary documentation.
I have verified that my changes do not introduce (new) build or analyzer warnings.
I ran all tests locally using the UA.slnx solution against at least .net framework and .net 10, and all passed.
I fixed all failing and flaky tests in the CI pipelines and all CodeQL warnings.
I have addressed all PR feedback received.

…xtra decoded children that should stay on the type definition such as Optional/Mandatory placeholders and ones that do not have Mandatory/Optional ModellingRules.

larws · 2026-06-29T16:54:37Z

Hi @mrsuciu, this breaks any server using a nodeset which uses any instances below a folder node which is contained as Organizes. Any machinery building blocks user is affected by this. What is the migration path?

mrsuciu · 2026-06-29T18:43:25Z

@larws Thanks for raising the issue. The PR looked ok for what it meant to fix but it looks that there are side effects. The changes have made it through in the Pre-release. They will either be reverted or a more comprehensive fix has to be done. Do not update to the Pre-release for the moment.

opcfoundation-org · 2026-06-30T10:17:21Z

@larws can you explain why it would break? the pruning was to ensure compliance with the specification. we need to determine if it is failing because the bug gave you something that the spec does not allow or if the implementation of the pruning is resulting in models that are not compliant.

larws · 2026-06-30T14:30:01Z

@opcfoundation-org We use the Machinery Companion Spec and it's elements defined by that specification. The model compiler generates for children of the MachineryBuildingBlocks folder as defined in https://reference.opcfoundation.org/specs/OPC-40001-1/6 an element in the m_children list, which is filled by the InitializationString. The reference used is HasAddIn not Organizes as mentioned earlier. In any case, those elements are incorrectly deleted by this change. I cannot provide you the nodeset we are using, but you can create a model based on the mentioned spec this is easily reproducable.

opcfoundation-org · 2026-07-01T10:05:12Z

@larws HasAddIn is just a subtype of HasComponent and is otherwise the same as HasComponent.

If you add a component to a type definition you need to set the modelling rule on the instance if you want it to be replicated in the instance.

i.e.
SpecificMachineType =HasAddIn=> MachineryBuildingBlocks => ModellingRule_Mandatory.
and
SpecificMachineType =HasAddIn=> MachineryBuildingBlocks =HasAddIn=> BuildingBlock1 => ModellingRule_Mandatory.

If ModellingRule_Mandatory or ModellingRule_Optional is omitted then the pruning is working as designed.
If it worked before it was because the SDK implemented the specification incorrectly.

Can you confirm that you do not have a ModellingRule defined on the HasAddIn Objects you have defined?

opcfoundation-org · 2026-07-01T11:36:43Z

Created a sample NodeSet:
opcua_demomachines_1.0.0-alpha_2026_07_01.xml

larws · 2026-07-02T06:54:08Z

@opcfoundation-org In our nodeset the nodes with HasAddIn references have all a ModellingRule defined, but the code generated by the model compiler does not set the ModellingRuleId property for the BaseInstantState instances. Our nodeset uses the same modelling as your sample nodeset. I do not know when I will find the time to reproduce this issue with your nodeset.
But as in #3770 mentioned this is not a problem that should be solved by the stack, but instead the tools generating the invalid code should be fixed.

opcfoundation-org · 2026-07-02T07:40:51Z

We will test with that sample NodeSet and see if there is a tool bug.

larws · 2026-07-07T14:23:38Z

@opcfoundation-org With https://github.com/larws/repro-issue-3843 you can reproduce the issue I am talking about. I generated the code for your demo nodeset with the current model compiler version and added it to a server. With version 1.5.378.152 it does not work, the AddIn nodes are not visible. With version 1.5.378.145 the BuildingBlock1 and BuildingBlock2 nodes are visible in the address space.

…nition only. (#3843)" (#3976) This reverts commit 00519fa. # Description Due to longer investigation time needed on ModelCompiler the pruning of the extra decoded children that should stay on the type definition only is reverted ## Related Issues _Reference all GitHub issues this PR addresses. If there is no issue yet, open one and link it here._ _If this is a relatively large or complex change, a design must have been discussed in the related tracking issue and signed off (which becomes the Architectural Decision Record (ADR))._ - Fixes #github-issue-number, ... ## Checklist _Put an `x` in the boxes that apply. You can complete these step by step after opening the PR._ - [ ] I have signed the [CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf) and read the [CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md) doc. - [ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage. - [ ] I have added all necessary documentation. - [ ] I have verified that my changes do not introduce (new) build or analyzer warnings. - [ ] I ran **all** tests locally using the **UA.slnx** solution against at least .net **framework** and .net **10**, and all passed. - [ ] I fixed **all** failing and flaky tests in the CI pipelines and **all** CodeQL warnings. - [ ] I have addressed **all** PR feedback received.

mrsuciu and others added 2 commits June 4, 2026 17:48

Keep the generated children that belong on instances, and prune the e…

604592f

…xtra decoded children that should stay on the type definition such as Optional/Mandatory placeholders and ones that do not have Mandatory/Optional ModellingRules.

Merge branch 'master378' into master378-PruneNonOptionalAndMandatory

858d8f8

romanett linked an issue Jun 6, 2026 that may be closed by this pull request

ProgramStateMachineState has wrong InitializationString and possible many other classes also #3770

Open

5 tasks

marcschier added the 1.5.378 Only affects 1.5.378 (pre 2.0) label Jun 9, 2026

mrsuciu marked this pull request as ready for review June 16, 2026 09:20

Merge branch 'master378' into master378-PruneNonOptionalAndMandatory

5e286ea

mrsuciu assigned romanett and marcschier Jun 16, 2026

marcschier approved these changes Jun 16, 2026

View reviewed changes

mrsuciu merged commit 00519fa into OPCFoundation:master378 Jun 17, 2026
51 checks passed

marcschier mentioned this pull request Jul 9, 2026

Issues with pruning - AddIns missing. #3972

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Prune extra decoded children that should stay on the type definition only.#3843

Prune extra decoded children that should stay on the type definition only.#3843
mrsuciu merged 3 commits into
OPCFoundation:master378from
mrsuciu:master378-PruneNonOptionalAndMandatory

mrsuciu commented Jun 4, 2026

Uh oh!

Uh oh!

larws commented Jun 29, 2026

Uh oh!

mrsuciu commented Jun 29, 2026 •

edited

Loading

Uh oh!

opcfoundation-org commented Jun 30, 2026

Uh oh!

larws commented Jun 30, 2026 •

edited

Loading

Uh oh!

opcfoundation-org commented Jul 1, 2026 •

edited

Loading

Uh oh!

opcfoundation-org commented Jul 1, 2026

Uh oh!

larws commented Jul 2, 2026

Uh oh!

opcfoundation-org commented Jul 2, 2026

Uh oh!

larws commented Jul 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

mrsuciu commented Jun 4, 2026

Description

Related Issues

Checklist

Uh oh!

Uh oh!

larws commented Jun 29, 2026

Uh oh!

mrsuciu commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

opcfoundation-org commented Jun 30, 2026

Uh oh!

larws commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

opcfoundation-org commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

opcfoundation-org commented Jul 1, 2026

Uh oh!

larws commented Jul 2, 2026

Uh oh!

opcfoundation-org commented Jul 2, 2026

Uh oh!

larws commented Jul 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mrsuciu commented Jun 29, 2026 •

edited

Loading

larws commented Jun 30, 2026 •

edited

Loading

opcfoundation-org commented Jul 1, 2026 •

edited

Loading