Prepare release 1.5.378 from master378 by mrsuciu · Pull Request #3638 · OPCFoundation/UA-.NETStandard

mrsuciu · 2026-03-25T12:32:00Z

Proposed changes

Describe the changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Related Issues

Fixes #

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

Bugfix (non-breaking change which fixes an issue)
Enhancement (non-breaking change which adds functionality)
Test enhancement (non-breaking change to increase test coverage)
Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

I have read the CONTRIBUTING doc.
I have signed the CLA.
I ran tests locally with my changes, all passed.
I fixed all failing tests in the CI pipelines.
I fixed all introduced issues with CodeQL and LGTM.
I have added tests that prove my fix is effective or that my feature works and increased code coverage.
I have added necessary documentation (if appropriate).
Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

…kenInvalid for failed verification (#3514) * Improve logging and fix UserNameIdentityToken to return BadIdentityTokenInvalid for failed verification Refactor DataChangeQueueHandler to return overflow status from QueueValue and Enqueue, updating MonitoredItem to log overflows accurately. Update IDataChangeQueueHandler interface accordingly. Enhance ConsoleTelemetry logger configuration management and ensure proper disposal of old logger factories. Change UserNameIdentityToken password/nonce failure to return BadIdentityTokenInvalid for more precise error reporting. To prevent the leakage of information useful to attackers, Servers shall ensure that the process of validating UserIdentityTokens completes in a fixed interval independent of whether an error occurs or not. The process of validation includes decrypting, check for padding and checking for a valid nonce. If any errors occur the return code is Bad_IdentityTokenInvalid. * fix GDS ApplicationNames to include the Locale * fix ctt testcase by allowing faster sampling for XmlNodeNode

…3521) * Ignore 0 references in data dictionary and provide better logging. * Update Libraries/Opc.Ua.Client.ComplexTypes/ComplexTypeSystem.cs Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>

… assembly loading (#3520) * Hook lookup of symbol in types project and set hook in opc ua core on assembly loading * Use module initializer instead of static constructor

This pull request modernizes the OPC UA .NET codebase and tests, removes .NET Standard 2.0 support from certificate/security code, and updates test code to use C# 12 and .NET 8+ features for clarity and maintainability. - Certificate and BouncyCastle interop files (e.g., CertificateBuilder.cs, X509Extensions.cs, X509SignatureFactory.cs) are refactored to drop NETSTANDARD2_0 support and use modern .NET APIs and conditional compilation. - Test code across the codebase is updated to use default, strongly-typed Parse methods, collection expressions, and improved async/await patterns. - Exception handling and assertions in tests are modernized, and test method naming is made consistent with Async suffixes. - The project and build files are updated to clarify Roslynator analyzer usage and remove obsolete netstandard tags. - General code and test cleanup includes improved null safety, type safety, and removal of deprecated or unused code.

…em variables. (#3530) * Enforce numeric DataTypes for AnalogItem variables Removed creation of non-numeric array AnalogItems and added a check to throw an exception if a non-numeric DataType is used. This ensures AnalogItems are restricted to numeric types, improving type safety and compliance. * Set default description

* add FindIssuerCAByKeyIdentifierAsync * remove unnecessary using for Org.BouncyCastle.Asn1.X9

* add Equals, change id generation * add equality operators and gethashcode * add override Equals * Copilot issues * fix TranslateEndpointDescriptionsTest, that relied on ServerUnique UserTokenPolicy Ids --------- Co-authored-by: Roman Ettlinger <[email protected]>

ServerBase.StopAsync() calls Close() on each transport listener then Clear() on the list. ServerBase.Dispose() later iterates TransportListeners to call Dispose() on each — but the list is already empty, so TcpTransportListener.Dispose() never runs. Add Utils.SilentDispose() after Close() in StopAsync to ensure TcpTransportListener.Dispose() executes before the list is cleared.

…led (#3559)

Cherry pick Bugfixes from 1.6 to 1.5.378

…3565) * [Client] Fixed freezing of Subscription with sequential publishing - Fixed freezing of Subscription (messages were not moving from Subscription.m_incomingMessages to Subscription.m_messageCache). Was happening when sequentialPublishing is active and first received publish response had SequenceNumber greater when 1. - Constant Subscription.kRepublishMessageTimeout was made public (Subscription.REPUBLISH_MESSAGE_TIMEOUT) so it can be used in tests. - Added unit tests to cover fixed problem. - Added unit test to cover invalid handling of reordered message queue for sequential publishing (UnorderedMessagesWouldBeLostForSequentialPublishingAsync). For now, test was made [Explicit]. * [PR] fix naming convention violation * [PR] removed region in tests (cherry picked from commit 6a09c1c)

… - BadIdentityTokenInvalid instead of rejected (#3591) * fix client session error code for Endpoint does not support the user identity type provided. * further places of BadIdentityTokenRejected * adjust test expectation (cherry picked from commit 6ea5902)

* test(type-info): add failing test * fix(type-info): require IEnumerable implementation before treating generic type as array * test(type-info): add test for coverage (cherry picked from commit 25a4882)

* test(numeric-range): add failing test * fix(numeric-range): include sub ranges in equality check * test(numeric-range): add tests for coverage (cherry picked from commit 56486ef)

…uring server restart (#3608) * Fix memory leak from undisposed sockets and retained event handlers during server restart When an OPC UA server is stopped and restarted in-process, TcpServerChannel instances were never garbage collected because UaSCBinaryChannel.Dispose() did not close the underlying socket. Pending ReceiveAsync operations kept the channels pinned via SocketAsyncEngine, causing a steady heap growth per cycle. Changes: - Close socket in UaSCBinaryChannel.Dispose() to cancel pending async I/O - Unsubscribe CertificateValidator.CertificateUpdate in StandardServer.Dispose() - Unsubscribe ConfigurationWatcher.Changed in StandardServer.Dispose() - Unsubscribe ConnectionStatusChanged from TransportListeners in ServerBase.Dispose() Verified over 786 restart cycles with stable heap. * Remove verbose comment * Remove redundant event unsubscribe before dispose * Remove duplicate CertificateUpdate unsubscribe (already existed in master) (cherry picked from commit eae41a5)

…abandoned subscriptions (#3617) (#3618) * fix(SubscriptionManager): replace List with ConcurrentDictionary for abandoned subscriptions (#3612) * replace the semaphore-protected `List<ISubscription>` used for abandoned subscriptions with a `readonly ConcurrentDictionary<uint, ISubscription>`, eliminating three separate lock acquisitions in `SessionClosed`, `DeleteSubscription`, and the publish loop * add `DeleteAbandonedSubscriptionsConcurrentlyAsync` integration test to cover the concurrent-delete scenario. * Fix build --------- Co-authored-by: Marc Schier <[email protected]> (cherry picked from commit b8856c9)

…loading paths (#3630) * Fix missing Commit() after LoadDictionaryDataTypesAsync in ComplexTypeSystem Co-authored-by: marcschier <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: marcschier <[email protected]> (cherry picked from commit 4c78751)

Backport changes from master to master378

CLAassistant · 2026-03-25T12:32:15Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
9 out of 11 committers have signed the CLA.

✅ mrsuciu
✅ richterr
✅ romanett
✅ KircMax
✅ RicoSuter
✅ JMolenkamp
✅ AnatolyKochnev
✅ marcschier
✅ cristipogacean
❌ raserle
❌ Copilot
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

KircMax · 2026-03-25T18:07:13Z

Is there a pre-release available that I could test?
On the preview feed I did not really see something > 11.02.2026 ?

Backport the reconnect/reactivate fix from 36dc85b to master378.

mrsuciu · 2026-03-26T11:48:53Z

@KircMax This release is based on the "stable" master378 branch which does not trigger automatic preview releases.

KircMax · 2026-03-26T13:13:57Z

@mrsuciu so I will be able to test it once there is a real release available, right?

Backport reconnect user token policy reuse to master378

mrsuciu · 2026-03-26T13:37:14Z

@KircMax Yes, it will be marked as pre-release for a while

mrsuciu and others added 26 commits February 2, 2026 10:11

Respect configured RSA key size when creating app certificates (#3513)

0cb20d6

fix minor xml docs copy error (#3518)

6d539c9

Hook lookup of symbol in types project and set hook in opc ua core on…

bafd63d

… assembly loading (#3520) * Hook lookup of symbol in types project and set hook in opc ua core on assembly loading * Use module initializer instead of static constructor

add FindIssuerCAByKeyIdentifierAsync (#3535)

f77e96e

* add FindIssuerCAByKeyIdentifierAsync * remove unnecessary using for Org.BouncyCastle.Asn1.X9

add throwing serviceresultexception with stacktrace (#3539)

39ac3f6

Fix memory leaks in server disposal (#3560)

55bc484

fix: Subscription diagnostic nodes not deleted when diagnostics disab…

cfcf03e

…led (#3559)

Merge pull request #3572 from OPCFoundation/romanett/cherryPickMaster378

a9a9c6c

Cherry pick Bugfixes from 1.6 to 1.5.378

Fix non enumerable generic type info construction (#3597)

11cebf8

* test(type-info): add failing test * fix(type-info): require IEnumerable implementation before treating generic type as array * test(type-info): add test for coverage (cherry picked from commit 25a4882)

Adapt TypeInfo tests to master378 API

0714b35

Fix numeric range equality (#3600)

c69484f

* test(numeric-range): add failing test * fix(numeric-range): include sub ranges in equality check * test(numeric-range): add tests for coverage (cherry picked from commit 56486ef)

Adapt ReferenceServer test to master378 APIs

2ac6547

Backport pipeline vm image updates to master378

7b726e0

Backport master Azure pipeline image updates

596b60e

Merge pull request #3632 from mrsuciu/fixes-master378

c31af06

Backport changes from master to master378

mrsuciu requested a review from romanett March 25, 2026 12:33

romanett approved these changes Mar 25, 2026

View reviewed changes

Backport reconnect user token policy reuse

77e65f4

Backport the reconnect/reactivate fix from 36dc85b to master378.

Merge pull request #3640 from mrsuciu/master378-backport36dc85b

87a8ee1

Backport reconnect user token policy reuse to master378

mrsuciu merged commit f52ae43 into release/1.5.378 Mar 26, 2026
106 of 108 checks passed

dependabot Bot mentioned this pull request Apr 28, 2026

Bump OPCFoundation.NetStandard.Opc.Ua.Bindings.Https and 11 others OPCFoundation/UA-.NETStandard-Samples#686

Merged

dependabot Bot mentioned this pull request May 12, 2026

Bump OPCFoundation.NetStandard.Opc.Ua.Core from 1.5.378.65 to 1.5.378.134 OPCFoundation/UA-ModelCompiler#242

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Prepare release 1.5.378 from master378#3638

Prepare release 1.5.378 from master378#3638
mrsuciu merged 28 commits into
release/1.5.378from
master378

mrsuciu commented Mar 25, 2026

Uh oh!

CLAassistant commented Mar 25, 2026 •

edited

Loading

Uh oh!

KircMax commented Mar 25, 2026

Uh oh!

mrsuciu commented Mar 26, 2026

Uh oh!

KircMax commented Mar 26, 2026

Uh oh!

mrsuciu commented Mar 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Uh oh!

Conversation

mrsuciu commented Mar 25, 2026

Proposed changes

Related Issues

Types of changes

Checklist

Further comments

Uh oh!

CLAassistant commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KircMax commented Mar 25, 2026

Uh oh!

mrsuciu commented Mar 26, 2026

Uh oh!

KircMax commented Mar 26, 2026

Uh oh!

mrsuciu commented Mar 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

CLAassistant commented Mar 25, 2026 •

edited

Loading