Proposed changes

FactoryBuilder.Commit() was never called when LoadDictionaryDataTypesAsync was the active loading path in LoadAsync and LoadNamespaceAsync. Both methods returned the dictionary load result directly, bypassing the commit. Any complex types registered during dictionary loading were silently dropped from the immutable EncodeableFactory, breaking all reads of those types.

Affected methods in ComplexTypeSystem.cs:

• LoadAsync — triggered when DisableDataTypeDefinition is set or LoadBaseDataTypesAsync returns false
• LoadNamespaceAsync — same condition

Fix: Replace the early return with a local allTypesLoaded variable, always call Commit(), then return the stored result — matching the pattern already used correctly in LoadTypeAsync:

// Before (broken): Commit() skipped
return await LoadDictionaryDataTypesAsync(serverEnumTypes, true, ct).ConfigureAwait(false);

// After (fixed): Commit() always called
bool allTypesLoaded;
if (DisableDataTypeDefinition || !await LoadBaseDataTypesAsync(...))
{
    allTypesLoaded = await LoadDictionaryDataTypesAsync(serverEnumTypes, true, ct).ConfigureAwait(false);
}
else
{
    allTypesLoaded = true;
}
m_complexTypeResolver.FactoryBuilder.Commit();
return allTypesLoaded;

Related Issues

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• Enhancement (non-breaking change which adds functionality)
• Test enhancement (non-breaking change to increase test coverage)
• Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
• Documentation Update (if none of the other choices apply)

Checklist

• I have read the CONTRIBUTING doc.
• I have signed the CLA.
• I ran tests locally with my changes, all passed.
• I fixed all failing tests in the CI pipelines.
• I fixed all introduced issues with CodeQL and LGTM.
• I have added tests that prove my fix is effective or that my feature works and increased code coverage.
• I have added necessary documentation (if appropriate).
• Any dependent changes have been merged and published in downstream modules.

Further comments

The regression was introduced in #3241 which added the immutable EncodeableFactory builder pattern. The LoadTypeAsync method had the correct structure (commit outside the conditional), but LoadAsync and LoadNamespaceAsync were not updated consistently.

• Fixes Broken immutable EncodeableFactory implementation #3629

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.