Skip to content

Fix numeric range equality#3600

Merged
marcschier merged 3 commits into
OPCFoundation:masterfrom
JMolenkamp:fix-numeric-range-equality
Mar 10, 2026
Merged

Fix numeric range equality#3600
marcschier merged 3 commits into
OPCFoundation:masterfrom
JMolenkamp:fix-numeric-range-equality

Conversation

@JMolenkamp

Copy link
Copy Markdown
Contributor

Proposed changes

Include NumericRange.SubRanges in equality check and hashcode.

Related Issues

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

@codecov

codecov Bot commented Mar 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.24%. Comparing base (d25caff) to head (936f424).
⚠️ Report is 138 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3600       +/-   ##
===========================================
+ Coverage   51.86%   66.24%   +14.37%     
===========================================
  Files         370      459       +89     
  Lines       78618    97726    +19108     
  Branches    13650    16379     +2729     
===========================================
+ Hits        40779    64743    +23964     
+ Misses      33705    27920     -5785     
- Partials     4134     5063      +929     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@romanett

romanett commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@romanett

romanett commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@marcschier
marcschier merged commit 56486ef into OPCFoundation:master Mar 10, 2026
116 of 117 checks passed
jnsjll pushed a commit to jnsjll/UA-.NETStandard that referenced this pull request Mar 12, 2026
* test(numeric-range): add failing test

* fix(numeric-range): include sub ranges in equality check

* test(numeric-range): add tests for coverage
mrsuciu pushed a commit to mrsuciu/UA-.NETStandard that referenced this pull request Mar 19, 2026
* test(numeric-range): add failing test

* fix(numeric-range): include sub ranges in equality check

* test(numeric-range): add tests for coverage

(cherry picked from commit 56486ef)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NumericRanges with different SubRanges are considered to be equal

3 participants