Skip to content

fix client session error code for Endpoint does not support usertoken - BadIdentityTokenInvalid instead of rejected#3591

Merged
marcschier merged 4 commits into
OPCFoundation:masterfrom
KircMax:KircMax/ClientServiceResultExceptionErrorCode
Mar 6, 2026
Merged

fix client session error code for Endpoint does not support usertoken - BadIdentityTokenInvalid instead of rejected#3591
marcschier merged 4 commits into
OPCFoundation:masterfrom
KircMax:KircMax/ClientServiceResultExceptionErrorCode

Conversation

@KircMax

@KircMax KircMax commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

…identity type provided.

Proposed changes

Describe the changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Related Issues

Discussion in #3012

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov

codecov Bot commented Mar 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.16%. Comparing base (d25caff) to head (c377e98).
⚠️ Report is 132 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3591       +/-   ##
===========================================
+ Coverage   51.86%   66.16%   +14.29%     
===========================================
  Files         370      459       +89     
  Lines       78618    97715    +19097     
  Branches    13650    16375     +2725     
===========================================
+ Hits        40779    64657    +23878     
+ Misses      33705    27986     -5719     
- Partials     4134     5072      +938     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcschier
marcschier merged commit 6ea5902 into OPCFoundation:master Mar 6, 2026
93 checks passed
jnsjll pushed a commit to jnsjll/UA-.NETStandard that referenced this pull request Mar 12, 2026
… - BadIdentityTokenInvalid instead of rejected (OPCFoundation#3591)

* fix client session error code for Endpoint does not support the user identity type provided.

* further places of BadIdentityTokenRejected

* adjust test expectation
mrsuciu pushed a commit to mrsuciu/UA-.NETStandard that referenced this pull request Mar 19, 2026
… - BadIdentityTokenInvalid instead of rejected (OPCFoundation#3591)

* fix client session error code for Endpoint does not support the user identity type provided.

* further places of BadIdentityTokenRejected

* adjust test expectation

(cherry picked from commit 6ea5902)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants