[Server] Include domains and applicationName in ServerCertificate for CreateSigningRequest Method with parameter regeneratePrivateKey = true#3263
Merged
marcschier merged 2 commits intoOct 22, 2025
Conversation
…gningRequestAsync with parameter regeneratePrivateKey = true
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the CreateSigningRequestMethod where domain names and application name were being lost when regenerating the private key for temporary application certificates.
- Extract domain names from existing certificate before regeneration
- Pass domain names to the certificate generation method
- Include application name in the certificate builder
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3263 +/- ##
==========================================
- Coverage 57.74% 57.63% -0.12%
==========================================
Files 365 365
Lines 79419 79421 +2
Branches 13865 13865
==========================================
- Hits 45862 45774 -88
- Misses 29310 29388 +78
- Partials 4247 4259 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marcschier
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This pull request updates the process for generating temporary application certificates to ensure that domain names from the existing certificate are preserved when regenerating the private key.
Related Issues
Checklistt
Further comments