Description

Fixes #2434 - Resolves InvalidCastException when calling GetBrowseName() methods on various constant classes.

Problem

The GetBrowseName() methods in Attributes, DataTypes, ReferenceTypes, and StatusCodes classes were throwing InvalidCastException when retrieving field values via reflection:

// This would throw: Unable to cast object of type 'System.Int32' to type 'System.UInt32'
string attributeBrowseName = Attributes.GetBrowseName(Attributes.Value);

Root Cause: When using reflection to retrieve const uint field values, field.GetValue() returns a boxed object. For values within the int range, the value is boxed as int rather than uint. Direct casting (uint)field.GetValue() throws an exception because you cannot directly cast a boxed int to uint.

Solution

1. Use Convert.ToUInt32(): Replace direct casts with Convert.ToUInt32(field.GetValue(...), CultureInfo.InvariantCulture) to properly handle the boxed value conversion.

2. Add type filtering: Include if (field.FieldType == typeof(uint)) checks to only process uint fields, avoiding potential issues with other static fields.

3. Code style compliance: Split long lines to meet the 160-character limit.

Changes

Fixed Classes

• Attributes.Helpers.cs - Fixed s_attributesIdToName dictionary initialization
• DataTypes.Helpers.cs - Fixed s_dataTypeIdToName dictionary initialization
• ReferenceTypes.Helpers.cs - Fixed s_referenceTypeIdToName dictionary initialization
• StatusCodes.Helpers.cs - Fixed both s_statusCodeToSymbol and s_utf8BrowseNames dictionary initializations
• Utils.cs - Fixed generic GetIdentifier() helper method
• DataGenerator.cs - Fixed StatusCode field reflection

Tests Added

Added comprehensive unit tests covering all fixed methods:

• AttributesTests.cs - 7 tests for Attributes class
• DataTypesTests.cs - 7 tests for DataTypes class
• ReferenceTypesTests.cs - 7 tests for ReferenceTypes class
• StatusCodesTests.cs - 10 tests for StatusCodes class (including UTF8 encoding)

Total: 31 new tests, all passing

Verification

✅ The exact scenario from the issue now works correctly
✅ All 31 new unit tests pass
✅ All 24,571 existing core tests pass (no regressions)
✅ Tested on .NET 8.0 as specified in the issue

Example Usage

// All of these now work without exceptions:
string attrName = Attributes.GetBrowseName(Attributes.Value);           // "Value"
string dataTypeName = DataTypes.GetBrowseName((int)DataTypes.Boolean);  // "Boolean"
string refTypeName = ReferenceTypes.GetBrowseName(ReferenceTypes.References); // "References"
string statusName = StatusCodes.GetBrowseName(StatusCodes.Good);        // "Good"

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.