[Server] Add Async MonitoredItem Management methods to MasterNodeManager & IAsyncNodeManager#3217
Merged
mrsuciu merged 25 commits intoSep 22, 2025
Conversation
…AsyncNodeManager Refactor MasterNodeManager to allow access to IAsyncNodeManager from NodeManagers & NamespaceManagers Properties
…stead of ref globalIdCounter
…eManagerMIMethods
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3217 +/- ##
==========================================
+ Coverage 57.58% 57.68% +0.10%
==========================================
Files 355 355
Lines 78549 78679 +130
Branches 13849 13857 +8
==========================================
+ Hits 45233 45389 +156
+ Misses 29069 29044 -25
+ Partials 4247 4246 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
romanett
marked this pull request as ready for review
September 21, 2025 18:19
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds asynchronous monitored item management methods to MasterNodeManager and IAsyncNodeManager. The changes introduce async versions of key monitored item operations including create, modify, delete, transfer, and monitoring mode management.
- Extends IAsyncNodeManager with async monitored item management interfaces
- Adds async method implementations to MasterNodeManager with synchronous fallbacks
- Updates AsyncNodeManagerAdapter to bridge between sync and async implementations
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| Tests/Opc.Ua.Server.Tests/MonitoredItemIdFactoryTests.cs | Code style improvements including explicit type declarations and collection checks |
| Libraries/Opc.Ua.Server/NodeManager/INodeManager.cs | Defines new async interfaces for monitored item operations and extends IAsyncNodeManager |
| Libraries/Opc.Ua.Server/NodeManager/MasterNodeManager.cs | Implements async monitored item methods with proper cancellation token handling |
| Libraries/Opc.Ua.Server/NodeManager/AsyncNodeManagerAdapter.cs | Provides adapter methods to bridge sync and async node manager implementations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
marcschier
approved these changes
Sep 22, 2025
mrsuciu
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add Async MonitoredItem Management methods to MasterNodeManager & IAsyncNodeManager
Types of changes
Checklist
Further comments