Skip to content

Retry to reactivate session on BadNoCommunication and BadConnectionClosed.#3197

Merged
mrsuciu merged 1 commit into
OPCFoundation:masterfrom
mrsuciu:raSessionOnBadNoCommunication
Sep 15, 2025
Merged

Retry to reactivate session on BadNoCommunication and BadConnectionClosed.#3197
mrsuciu merged 1 commit into
OPCFoundation:masterfrom
mrsuciu:raSessionOnBadNoCommunication

Conversation

@mrsuciu

@mrsuciu mrsuciu commented Sep 15, 2025

Copy link
Copy Markdown
Contributor

Proposed changes

Retry to reactivate session also when BadNoCommunication and BadConnectionClosed status codes are handled.

Related Issues

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov

codecov Bot commented Sep 15, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.40%. Comparing base (d8d4c74) to head (21c39c0).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...s/Opc.Ua.Client/Session/SessionReconnectHandler.cs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3197      +/-   ##
==========================================
- Coverage   57.63%   57.40%   -0.23%     
==========================================
  Files         355      355              
  Lines       78105    78537     +432     
  Branches    13821    13854      +33     
==========================================
+ Hits        45017    45088      +71     
- Misses      28856    29188     +332     
- Partials     4232     4261      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@romanett

Copy link
Copy Markdown
Contributor

Can we somehow try to add a Test for the reconnect handler in the Future? We could simulate Common failures

@mrsuciu
mrsuciu merged commit d130b49 into OPCFoundation:master Sep 15, 2025
75 of 77 checks passed
mrsuciu added a commit to mrsuciu/UA-.NETStandard that referenced this pull request Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BadNoCommunication StatusCode is not treated as a recoverable communication error that should trigger session reactivation attempts.

2 participants