Retry to reactivate session on BadNoCommunication and BadConnectionClosed.#3197
Merged
mrsuciu merged 1 commit intoSep 15, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3197 +/- ##
==========================================
- Coverage 57.63% 57.40% -0.23%
==========================================
Files 355 355
Lines 78105 78537 +432
Branches 13821 13854 +33
==========================================
+ Hits 45017 45088 +71
- Misses 28856 29188 +332
- Partials 4232 4261 +29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
romanett
approved these changes
Sep 15, 2025
Contributor
|
Can we somehow try to add a Test for the reconnect handler in the Future? We could simulate Common failures |
mrsuciu
added a commit
to mrsuciu/UA-.NETStandard
that referenced
this pull request
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…
Proposed changes
Retry to reactivate session also when BadNoCommunication and BadConnectionClosed status codes are handled.
Related Issues
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...