[Server] Fix TranslateBrowsePath to NodeIds sync path in MasterNodeManager#3195
Merged
marcschier merged 3 commits intoSep 15, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3195 +/- ##
==========================================
+ Coverage 57.34% 57.40% +0.05%
==========================================
Files 355 355
Lines 78535 78538 +3
Branches 13854 13855 +1
==========================================
+ Hits 45037 45084 +47
+ Misses 29247 29195 -52
- Partials 4251 4259 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marcschier
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
In the current state of MasterNodeManager sync paths are still needed, but not called when the server is in operation with our default request queue.
This PR fixes an issue in the sync path, where await was used although the method was expected to finish synchronously.