[Server] Improve SubscriptionManager throughput by removing lock on subscription dictionary lookups#3189
Merged
marcschier merged 4 commits intoSep 11, 2025
Conversation
…on dictionary lookups
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3189 +/- ##
==========================================
- Coverage 58.03% 57.62% -0.41%
==========================================
Files 357 355 -2
Lines 78116 78077 -39
Branches 13820 13822 +2
==========================================
- Hits 45335 44993 -342
- Misses 28607 28848 +241
- Partials 4174 4236 +62 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves SubscriptionManager throughput by replacing dictionary lock-based operations with thread-safe concurrent collections, eliminating the need for explicit locking on subscription lookups and modifications.
- Replaces Dictionary with ConcurrentDictionary for subscription storage
- Removes lock statements around subscription dictionary operations
- Updates dictionary operations to use thread-safe TryAdd/TryRemove methods
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
romanett
marked this pull request as ready for review
September 8, 2025 04:15
marcschier
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Improve SubscriptionManager throughput by removing lock on subscription dictionary lookups
Types of changes
Checklist
Further comments