Make IAsyncNodeManager experimental / Remove deprecated ICertificateStoreMembers / Rename IApplicationConfigurationBuilderCreate.Create to CreateAsync#3187
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3187 +/- ##
==========================================
- Coverage 58.03% 57.66% -0.38%
==========================================
Files 357 355 -2
Lines 78116 78100 -16
Branches 13820 13820
==========================================
- Hits 45335 45033 -302
- Misses 28607 28833 +226
- Partials 4174 4234 +60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
romanett
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR focuses on cleaning up deprecated interfaces and making experimental APIs more explicit. The main purpose is to remove obsolete synchronous methods from the certificate store interfaces and mark the IAsyncNodeManager interface as experimental.
Key changes:
- Removal of all obsolete synchronous certificate store methods marked with
[Obsolete]attributes - Addition of
[Experimental]attribute to IAsyncNodeManager interface with proper documentation - Access modifier change for CallInternalAsync method from public to protected
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ICertificateStore.cs | Removes obsolete synchronous method declarations from interface |
| X509CertificateStore.cs | Removes obsolete synchronous method implementations |
| DirectoryCertificateStore.cs | Removes obsolete synchronous method implementations |
| CertificateIdentifier.cs | Removes obsolete synchronous method implementations |
| INodeManager.cs | Adds experimental attribute and documentation to IAsyncNodeManager |
| MasterNodeManager.cs | Changes CallInternalAsync visibility from public to protected |
| .editorconfig | Adds suppression for experimental API diagnostic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
romanett
marked this pull request as draft
September 5, 2025 15:26
marcschier
approved these changes
Sep 5, 2025
romanett
marked this pull request as ready for review
September 6, 2025 08:21
romanett
changed the title
marcschier
reviewed
Sep 8, 2025
marcschier
approved these changes
Sep 9, 2025
mrsuciu
pushed a commit
to mrsuciu/UA-.NETStandard
that referenced
this pull request
Sep 15, 2025
…toreMembers / Rename IApplicationConfigurationBuilderCreate.Create to CreateAsync (OPCFoundation#3187) * Make IAsyncNodeManager experimental * Remove deprecated ICertificateStore Members * rename IApplicationConfigurationBuilderCreate Create method to CreateAsync * Add obsolete create
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Related Issues
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...