[Client] Set default timout hint based on OperationTimeout of the TransportChannel#3178
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a default timeout hint mechanism to the ClientBase class by setting the TimeoutHint in request headers based on the OperationTimeout of the transport channel when no explicit timeout is provided.
- Automatically sets
TimeoutHintto theOperationTimeoutvalue when it's not explicitly specified (value is 0) - Enables servers to cancel long-running requests after the timeout period expires
- Improves request management by providing default timeout behavior
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3178 +/- ##
=======================================
Coverage 57.65% 57.66%
=======================================
Files 365 365
Lines 79412 79419 +7
Branches 13862 13865 +3
=======================================
+ Hits 45788 45798 +10
- Misses 29370 29373 +3
+ Partials 4254 4248 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marcschier
approved these changes
Aug 26, 2025
romanett
changed the title
romanett
marked this pull request as draft
August 28, 2025 04:05
Contributor
Author
|
Better Introduce a separate Property to allow to configure the "DefaultServiceCallTimeoutHint" |
romanett
marked this pull request as ready for review
October 12, 2025 10:44
marcschier
approved these changes
Oct 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR make the ClientBase class set a default Operation Timeout that allows the server to cancel longrunning requests after the Timeout expired.
Types of changes
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...