Update for 1.5.5 release with Async Service Calls#3116
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3116 +/- ##
==========================================
+ Coverage 57.48% 57.74% +0.26%
==========================================
Files 357 357
Lines 69113 70350 +1237
Branches 14201 14540 +339
==========================================
+ Hits 39729 40625 +896
- Misses 25136 25416 +280
- Partials 4248 4309 +61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mrsuciu
left a comment
mrsuciu
left a comment
There was a problem hiding this comment.
The newly added CallAsync overrides apparently intend to prioritize the OnCallAsync callbacks against the OnCall callbacks. If both callbacks are set than the apparent intent is not going to work and the OnCallAsync callback will be called for no reason before the OnCall callback. Shouldn't the OnCallAsync callback populate the output arguments and return the result imediatly ? Is my assumption about the priority intend wrong ?
mrsuciu
left a comment
mrsuciu
left a comment
There was a problem hiding this comment.
See comment regarding the possibility of OnCallAsync to be called unintendedly before OnCall if both are set.
5 participants
Updated generated files.