core: libtomcrypt: increase MPI_MEMPOOL_SIZE to 46kB#5065
Merged
jforissier merged 1 commit intoOP-TEE:masterfrom Dec 17, 2021
Merged
core: libtomcrypt: increase MPI_MEMPOOL_SIZE to 46kB#5065jforissier merged 1 commit intoOP-TEE:masterfrom
jforissier merged 1 commit intoOP-TEE:masterfrom
Conversation
Contributor
|
|
Contributor
Author
Tag updated |
etienne-lms
reviewed
Dec 17, 2021
Contributor
etienne-lms
left a comment
etienne-lms
left a comment
There was a problem hiding this comment.
Acked-by: Etienne Carriere <[email protected]>
This value is increased because xtest pkcs11_1019 when run in loop, leads to extensive use of memory pool which sometimes leads to memory allocation failure. Problem is the way mempool_alloc() is implemented in combination with how it's used from ltc_ecc_projective_add_point(). mempool_alloc() has a stack like allocation scheme. When freeing the top element that memory is returned to the pool, but if memory further down is free it's not returned until all elements above has been freed. If two or more elements gets allocated and freed in a cycle they can continue to use more and more memory with nothing returned. Signed-off-by: Sahil Malhotra <[email protected]> Reviewed-by: Jens Wiklander <[email protected]> Acked-by: Etienne Carriere <[email protected]> Fixes: OP-TEE#5022
Contributor
Author
Tag updated |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This value is increased because xtest pkcs11_1019 when run
in loop, leads to extensive use of memory pool which
sometimes leads to memory allocation failure.
Problem is the way mempool_alloc() is implemented in combination
with how it's used from ltc_ecc_projective_add_point().
mempool_alloc() has a stack like allocation scheme. When freeing
the top element that memory is returned to the pool, but if memory
further down is free it's not returned until all elements above has
been freed. If two or more elements gets allocated and freed in a
cycle they can continue to use more and more memory with nothing
returned.
Signed-off-by: Sahil Malhotra [email protected]
Fixes: #5022