Feature/patch pre crypto#3222
Merged
jforissier merged 6 commits intoOP-TEE:masterfrom Aug 29, 2019
Merged
Conversation
Add functions sev() and wfe() to implememt assembly instructions WFE/SEV. Signed-off-by: Cedric Neveux <[email protected]> Reviewed-by: Jens Wiklander <[email protected]> Reviewed-by: Etienne Carriere <[email protected]>
Add registers to handle CAAM clocks Signed-off-by: Cedric Neveux <[email protected]> Acked-by: Jens Wiklander <[email protected]>
Add DT functions: dt_get_irq() get the interrupt number of a node dt_disable_status() disable the 'status' field of node's prop dt_enable_secure_status() set 'secure-status' field of node's prop and disable the 'status' field in the same time Signed-off-by: Cedric Neveux <[email protected]> Acked-by: Jens Wiklander <[email protected]>
This change moves the DT pack operation at the end of the generic boot, in release_external_dt(). This change allows any driver or initialization function to change the DT and get its content repacked before DT is accessed by another boot agent. Signed-off-by: Cedric Neveux <[email protected]> Acked-by: Jens Wiklander <[email protected]> Reviewed-by: Etienne Carriere <[email protected]>
Add 32 and 64 bits little endian put/get functions Signed-off-by: Cedric Neveux <[email protected]> Reviewed-by: Etienne Carriere <[email protected]>
Add the read_ctr_el0 function in the arm64.h file Signed-off-by: Cedric Neveux <[email protected]> Reviewed-by: Jens Wiklander <[email protected]>
etienne-lms
reviewed
Aug 28, 2019
Contributor
etienne-lms
left a comment
etienne-lms
left a comment
There was a problem hiding this comment.
comments for "core: add DT function to read/modify DT"
| * | ||
| * Returns 0 on success or -1 on failure | ||
| */ | ||
| int dt_enable_secure_status(void *fdt, int node); |
Contributor
There was a problem hiding this comment.
suggest to rename dt_enable_secure_only_status().
Contributor
There was a problem hiding this comment.
well... dt_enable_secure_only_status() is as confusing as dt_enable_secure_status().
Discard my comment.
| return -1; | ||
| } | ||
|
|
||
| if (fdt_setprop_string(fdt, node, "secure-status", "okay")) |
Contributor
There was a problem hiding this comment.
suggest at line 112:
assert(!fdt_getprop(fdt, node, "secure-status", &len) ||
len >= sizeof("okay"));
Contributor
Author
There was a problem hiding this comment.
I don't understand why, could you explain?
Below is the description of the fdt_setprop_string saying that the property length will be the length of the string to set. Hence the len >= sizeof("okay") will never occurred.
/**
- fdt_setprop_string - set a property to a string value
- @fdt: pointer to the device tree blob
- @nodeoffset: offset of the node whose property to change
- @name: name of the property to change
- @str: string value for the property
- fdt_setprop_string() sets the value of the named property in the
- given node to the given string value (using the length of the
- string to determine the new length of the property), or creates a
- new property with that value if it does not already exist.
- This function may insert or delete data from the blob, and will
- therefore change the offsets of some existing nodes.
*/
Contributor
There was a problem hiding this comment.
ok, you're right. discard my comment.
etienne-lms
approved these changes
Aug 28, 2019
jenswi-linaro
approved these changes
Aug 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modification/addition of core features to start integration of HW Cryptographic driver (NXP CAAM HW module).