Update Notice.md

Build information includes:

- Version string as returned by 'git describe --dirty'
- Build counter (#1 initially or after 'make clean')
- Build date
- Link format

For example:

0.2.0-107-g4d0acfc #1 Tue May 12 16:02:57 UTC 2015 elf32-littlearm

Signed-off-by: Jerome Forissier <[email protected]>

Build information includes:

- Version string as returned by 'git describe --dirty'
- Build counter (#1 initially or after 'make clean')
- Build date/time
- Linker architecture ('arm', 'aarch64')

For example: 0.2.0-107-g985d7d8 #1 Tue May 12 16:49:14 UTC 2015 aarch64

Signed-off-by: Jerome Forissier <[email protected]>

Build information includes:

- Version string as returned by 'git describe --always --dirty'
- Build counter (#1 initially or after 'make clean')
- Build date/time
- Linker architecture ('arm', 'aarch64')

For example: 0.2.0-107-g985d7d8 #1 Tue May 12 16:49:14 UTC 2015 aarch64

Signed-off-by: Jerome Forissier <[email protected]>

Build information includes:

- Version string as returned by 'git describe --always --dirty'
- Build counter (#1 initially or after 'make clean')
- Build date/time
- Linker architecture ('arm', 'aarch64')

For example: 0.2.0-107-g985d7d8 #1 Tue May 12 16:49:14 UTC 2015 aarch64

Signed-off-by: Jerome Forissier <[email protected]>
Reviewed-by: Joakim Bech <[email protected]>
Reviewed-by: Pascal Brand <[email protected]>
Reviewed-by: Jens Wiklander <[email protected]>

Signed-off-by: Jerome Forissier <[email protected]>

There is a race condition in the code that creates and deletes trusted
storage. If multiple threads invoke a multi-session TA to create and
delete different files (such as xtest 6016), the following can occur:

    Thread #1 (create file #1) |   Thread #2 (delete file #2)
                               |
                               |   remove("/TA_dir/file");
    mkdir("/TA_dir");          |
                               |   rmdir("/TA_dir");
    create("/TA_dir/file1");   |
      => ENOENT                |

Add a mutex to prevent this race condition.

Note: the bug is currently not triggered by xtest 1016 because the test
is run for RPMB FS only, and because directory operations are no-ops in
the RPMB implementation. The fix will be needed when enabling single-TA
concurrency with the REE and SQL backends.

Signed-off-by: Jerome Forissier <[email protected]>

There is a race condition in the code that creates and deletes trusted
storage. If multiple threads invoke a multi-session TA to create and
delete different files (such as xtest 6016), the following can occur:

    Thread #1 (create file #1) |   Thread #2 (delete file #2)
                               |
                               |   unlink("/TA_dir/file2");
    mkdir("/TA_dir");          |
                               |   rmdir("/TA_dir");
    create("/TA_dir/file1");   |
      => ENOENT                |

Add a mutex to prevent this race condition.

Note: the bug is currently not triggered by xtest 1016 because the test
is run for RPMB FS only, and because directory operations are no-ops in
the RPMB implementation. The fix will be needed when enabling single-TA
concurrency with the REE and SQL backends.

Signed-off-by: Jerome Forissier <[email protected]>

The first and and fourth lines in the boot sequence below are debug
messages that should not be printed when the log level is INFO:

 INFO:    TEE-CORE: No NSEC DDR memory area defined
 INFO:    TEE-CORE:
 INFO:    TEE-CORE: OP-TEE version: 2.5.0-rc1 #1 Wed Jun 28 15:11:06 UTC 2017 aarch64
 INFO:    TEE-CORE: Shared memory address range: 3dc00000, 3f000000
 INFO:    TEE-CORE: Initialized

Signed-off-by: Jerome Forissier <[email protected]>

The first and and fourth lines in the boot sequence below are debug
messages that should not be printed when the log level is INFO:

 INFO:    TEE-CORE: No NSEC DDR memory area defined
 INFO:    TEE-CORE:
 INFO:    TEE-CORE: OP-TEE version: 2.5.0-rc1 #1 Wed Jun 28 15:11:06 UTC 2017 aarch64
 INFO:    TEE-CORE: Shared memory address range: 3dc00000, 3f000000
 INFO:    TEE-CORE: Initialized

Signed-off-by: Jerome Forissier <[email protected]>
Reviewed-by: Etienne Carriere <[email protected]>

The first and and fourth lines in the boot sequence below are debug
messages that should not be printed when the log level is INFO:

 INFO:    TEE-CORE: No NSEC DDR memory area defined
 INFO:    TEE-CORE:
 INFO:    TEE-CORE: OP-TEE version: 2.5.0-rc1 #1 Wed Jun 28 15:11:06 UTC 2017 aarch64
 INFO:    TEE-CORE: Shared memory address range: 3dc00000, 3f000000
 INFO:    TEE-CORE: Initialized

Signed-off-by: Jerome Forissier <[email protected]>
Reviewed-by: Etienne Carriere <[email protected]>

Replaces right shift operations on 32-bit integers by more than 31 bits
with 0.

This fixes coverity scan:
CID 1501844 (#1 of 1): Bad bit shift operation (BAD_SHIFT)

Signed-off-by: Jens Wiklander <[email protected]>

In tee_fs_dirfile_get_tmp() dirh->files is checked to be not NULL
leading but at another place dirh->nbits is checked instead before
accessing dirh->files. Both checks are OK since dirh->files mustn't be
NULL if dirh->nbits is larger than 0.

This confuses coverity to emit a warning, so change the function to
check dirh->nbits instead.

This fixes coverity scan:
CID 1501821 (#1 of 1): Dereference after null check (FORWARD_NULL)

Signed-off-by: Jens Wiklander <[email protected]>

In populate_files() db->files is checked to be not NULL leading but at
another place db->nbits is checked instead before accessing db->files.
Both checks are OK since db->files mustn't be NULL if db->nbits is
larger than 0.

This confuses coverity to emit a warning, so change the function to
check db->nbits instead.

This fixes coverity scan:
CID 1501793 (#1 of 1): Dereference after null check (FORWARD_NULL)

Signed-off-by: Jens Wiklander <[email protected]>