Build fixes#11
Merged
1 commit merged intoOP-TEE:masterfrom Aug 5, 2014
Merged
Conversation
- Move -lteec at the end of the link line to fix the following undefined reference: $ make CROSS_COMPILE=arm-linux-gnueabihf- ... tee_supplicant.c:(.text+0xdc): undefined reference to `_dprintf' ... - Add makefile dependency to fix the following: $ make -j3 CROSS_COMPILE=arm-linux-gnueabihf- ... cp out/libteec/libteec.so* out/export/lib cp: cannot stat ‘out/libteec/libteec.so*’: No such file or directory make: *** [copy_export] Error 1
Merged
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
Dec 12, 2020
Allow C_InitToken() to transport a null PIN reference as when protected authentication path is used. Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Base Specification Version 2.40 Plus Errata 01 C_InitPIN Signed-off-by: Vesa Jääskeläinen <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
Dec 12, 2020
Allow C_Login() to transport a null PIN reference as when protected authentication path is used. Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Base Specification Version 2.40 Plus Errata 01 C_Login Signed-off-by: Vesa Jääskeläinen <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
Dec 12, 2020
Allow C_InitPIN() to transport a null PIN reference as when protected authentication path is used. Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Base Specification Version 2.40 Plus Errata 01 C_InitPIN Signed-off-by: Vesa Jääskeläinen <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
Dec 12, 2020
Allow C_SetPIN() to transport a null PIN reference as when protected authentication path is used. Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Base Specification Version 2.40 Plus Errata 01 C_SetPIN Signed-off-by: Vesa Jääskeläinen <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
Dec 18, 2020
Allow C_InitToken() to transport a null PIN reference as when protected authentication path is used. Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Base Specification Version 2.40 Plus Errata 01 C_InitPIN Signed-off-by: Vesa Jääskeläinen <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
Dec 18, 2020
Allow C_InitPIN() to transport a null PIN reference as when protected authentication path is used. Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Base Specification Version 2.40 Plus Errata 01 C_InitPIN Signed-off-by: Vesa Jääskeläinen <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
Dec 18, 2020
Allow C_SetPIN() to transport a null PIN reference as when protected authentication path is used. Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Base Specification Version 2.40 Plus Errata 01 C_SetPIN Signed-off-by: Vesa Jääskeläinen <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
Dec 20, 2020
Allow C_InitToken() to transport a null PIN reference as when protected authentication path is used. Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Base Specification Version 2.40 Plus Errata 01 C_InitPIN Signed-off-by: Vesa Jääskeläinen <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
Dec 20, 2020
Allow C_Login() to transport a null PIN reference as when protected authentication path is used. Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Base Specification Version 2.40 Plus Errata 01 C_Login Signed-off-by: Vesa Jääskeläinen <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
Dec 20, 2020
Allow C_InitPIN() to transport a null PIN reference as when protected authentication path is used. Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Base Specification Version 2.40 Plus Errata 01 C_InitPIN Signed-off-by: Vesa Jääskeläinen <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
Dec 20, 2020
Allow C_SetPIN() to transport a null PIN reference as when protected authentication path is used. Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Base Specification Version 2.40 Plus Errata 01 C_SetPIN Signed-off-by: Vesa Jääskeläinen <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
Dec 20, 2020
Allow C_InitToken() to transport a null PIN reference as when protected authentication path is used. Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Base Specification Version 2.40 Plus Errata 01 C_InitPIN Signed-off-by: Vesa Jääskeläinen <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
Dec 20, 2020
Allow C_Login() to transport a null PIN reference as when protected authentication path is used. Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Base Specification Version 2.40 Plus Errata 01 C_Login Signed-off-by: Vesa Jääskeläinen <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
Dec 20, 2020
Allow C_InitPIN() to transport a null PIN reference as when protected authentication path is used. Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Base Specification Version 2.40 Plus Errata 01 C_InitPIN Signed-off-by: Vesa Jääskeläinen <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
Dec 20, 2020
Allow C_SetPIN() to transport a null PIN reference as when protected authentication path is used. Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Base Specification Version 2.40 Plus Errata 01 C_SetPIN Signed-off-by: Vesa Jääskeläinen <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
Dec 30, 2020
Allow C_InitToken() to transport a null PIN reference as when protected authentication path is used. Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Base Specification Version 2.40 Plus Errata 01 C_InitPIN Signed-off-by: Vesa Jääskeläinen <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
Dec 30, 2020
Allow C_Login() to transport a null PIN reference as when protected authentication path is used. Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Base Specification Version 2.40 Plus Errata 01 C_Login Signed-off-by: Vesa Jääskeläinen <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
Dec 30, 2020
Allow C_InitPIN() to transport a null PIN reference as when protected authentication path is used. Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Base Specification Version 2.40 Plus Errata 01 C_InitPIN Signed-off-by: Vesa Jääskeläinen <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
Dec 30, 2020
Allow C_SetPIN() to transport a null PIN reference as when protected authentication path is used. Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Base Specification Version 2.40 Plus Errata 01 C_SetPIN Signed-off-by: Vesa Jääskeläinen <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
Dec 30, 2020
Parse result buffer also for CKR_ATTRIBUTE_SENSITIVE and CKR_ATTRIBUTE_TYPE_INVALID. Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Base Specification Version 2.40 Plus Errata 01 C_GetAttributeValue Signed-off-by: Vesa Jääskeläinen <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
Dec 31, 2020
Parse result buffer also for CKR_ATTRIBUTE_SENSITIVE and CKR_ATTRIBUTE_TYPE_INVALID. Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Base Specification Version 2.40 Plus Errata 01 C_GetAttributeValue Signed-off-by: Vesa Jääskeläinen <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
Jan 6, 2021
Allow C_InitToken() to transport a null PIN reference as when protected authentication path is used. Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Base Specification Version 2.40 Plus Errata 01 C_InitPIN Signed-off-by: Vesa Jääskeläinen <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
Jan 6, 2021
Allow C_Login() to transport a null PIN reference as when protected authentication path is used. Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Base Specification Version 2.40 Plus Errata 01 C_Login Signed-off-by: Vesa Jääskeläinen <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
Jan 6, 2021
Allow C_InitPIN() to transport a null PIN reference as when protected authentication path is used. Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Base Specification Version 2.40 Plus Errata 01 C_InitPIN Signed-off-by: Vesa Jääskeläinen <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
Jan 6, 2021
Allow C_SetPIN() to transport a null PIN reference as when protected authentication path is used. Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Base Specification Version 2.40 Plus Errata 01 C_SetPIN Signed-off-by: Vesa Jääskeläinen <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
Jan 7, 2021
Allow C_InitToken() to transport a null PIN reference as when protected authentication path is used. Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Base Specification Version 2.40 Plus Errata 01 C_InitPIN Reviewed-by: Etienne Carriere <[email protected]> Signed-off-by: Vesa Jääskeläinen <[email protected]>
ruchi393
pushed a commit
to ruchi393/optee_client
that referenced
this pull request
Mar 8, 2021
Error code CKR_DATA_LEN_RANGE is mentioned in [1] for the mechanisms CKM_AES_ECB_ENCRYPT_DATA, CKM_AES_ECB_DECRYPT_DATA even though not explicitly specified in [2]. So, add it in the allowed error codes for C_DeriveKey(). [1] - Section 2.15.3 in "PKCS OP-TEE#11 Cryptographic Token Interface Current Mechanisms Specification Version 2.40 Plus Errata 01" [2] - "PKCS OP-TEE#11 Cryptographic Token Interface Base Specification Version 2.40 Plus Errata 01" Reviewed-by: Vesa Jääskeläinen <[email protected]> Signed-off-by: Ruchika Gupta <[email protected]>
ruchi393
pushed a commit
to ruchi393/optee_client
that referenced
this pull request
Mar 8, 2021
Error code CKR_DATA_LEN_RANGE is mentioned in [1] for the mechanisms CKM_AES_ECB_ENCRYPT_DATA, CKM_AES_ECB_DECRYPT_DATA even though not explicitly specified in [2]. So, add it in the allowed error codes for C_DeriveKey(). [1] - Section 2.15.3 in "PKCS OP-TEE#11 Cryptographic Token Interface Current Mechanisms Specification Version 2.40 Plus Errata 01" [2] - "PKCS OP-TEE#11 Cryptographic Token Interface Base Specification Version 2.40 Plus Errata 01" Reviewed-by: Etienne Carriere <[email protected]> Reviewed-by: Vesa Jääskeläinen <[email protected]> Signed-off-by: Ruchika Gupta <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
Mar 8, 2021
Implements support for digest operations as specified in: PKCS OP-TEE#11 Cryptographic Token Interface Base Specification Version 2.40 Plus Errata 01 5.10 Message digesting functions Signed-off-by: Vesa Jääskeläinen <[email protected]>
jforissier
pushed a commit
that referenced
this pull request
Mar 8, 2021
Error code CKR_DATA_LEN_RANGE is mentioned in [1] for the mechanisms CKM_AES_ECB_ENCRYPT_DATA, CKM_AES_ECB_DECRYPT_DATA even though not explicitly specified in [2]. So, add it in the allowed error codes for C_DeriveKey(). [1] - Section 2.15.3 in "PKCS #11 Cryptographic Token Interface Current Mechanisms Specification Version 2.40 Plus Errata 01" [2] - "PKCS #11 Cryptographic Token Interface Base Specification Version 2.40 Plus Errata 01" Reviewed-by: Etienne Carriere <[email protected]> Reviewed-by: Vesa Jääskeläinen <[email protected]> Signed-off-by: Ruchika Gupta <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
Mar 8, 2021
Implements support for digest operations as specified in: PKCS OP-TEE#11 Cryptographic Token Interface Base Specification Version 2.40 Plus Errata 01 5.10 Message digesting functions Reviewed-by: Ruchika Gupta <[email protected]> Reviewed-by: Etienne Carriere <[email protected]> Signed-off-by: Vesa Jääskeläinen <[email protected]>
eaaltonen
pushed a commit
to eaaltonen/optee_client
that referenced
this pull request
Mar 8, 2021
Add a CLI that can be used to configure tokens for: * standard PIN based login * Access Control List (ACL) based group login The PKCS OP-TEE#11 Cryptographic Token Interface does not include ACL based login. The CLI provides a more user friendly way of configuring the tokens for ACL group based login. Signed-off-by: Eero Aaltonen <[email protected]>
eaaltonen
pushed a commit
to eaaltonen/optee_client
that referenced
this pull request
Mar 8, 2021
Add a CLI that can be used to configure tokens for: * standard PIN based login * Access Control List (ACL) based group login The PKCS OP-TEE#11 Cryptographic Token Interface does not include ACL based login. The CLI provides a more user friendly way of configuring the tokens for ACL group based login. Signed-off-by: Eero Aaltonen <[email protected]>
jforissier
pushed a commit
that referenced
this pull request
Mar 8, 2021
Implements support for digest operations as specified in: PKCS #11 Cryptographic Token Interface Base Specification Version 2.40 Plus Errata 01 5.10 Message digesting functions Reviewed-by: Ruchika Gupta <[email protected]> Reviewed-by: Etienne Carriere <[email protected]> Signed-off-by: Vesa Jääskeläinen <[email protected]>
eaaltonen
pushed a commit
to eaaltonen/optee_client
that referenced
this pull request
Mar 17, 2021
Add a CLI that can be used to configure tokens for: * standard PIN based login * Access Control List (ACL) based group login The PKCS OP-TEE#11 Cryptographic Token Interface does not include ACL based login. The CLI provides a more user friendly way of configuring the tokens for ACL group based login. Signed-off-by: Eero Aaltonen <[email protected]>
eaaltonen
pushed a commit
to eaaltonen/optee_client
that referenced
this pull request
Mar 30, 2021
Add a CLI that can be used to configure tokens for: * standard PIN based login * Access Control List (ACL) based group login The PKCS OP-TEE#11 Cryptographic Token Interface does not include ACL based login. The CLI provides a more user friendly way of configuring the tokens for ACL group based login. Signed-off-by: Eero Aaltonen <[email protected]>
eaaltonen
pushed a commit
to eaaltonen/optee_client
that referenced
this pull request
Mar 30, 2021
Add a CLI that can be used to configure tokens for: * standard PIN based login * Access Control List (ACL) based group login The PKCS OP-TEE#11 Cryptographic Token Interface does not include ACL based login. The CLI provides a more user friendly way of configuring the tokens for ACL group based login. Signed-off-by: Eero Aaltonen <[email protected]>
eaaltonen
pushed a commit
to eaaltonen/optee_client
that referenced
this pull request
Apr 1, 2021
Add a CLI that can be used to configure tokens for: * standard PIN based login * Access Control List (ACL) based group login The PKCS OP-TEE#11 Cryptographic Token Interface does not include ACL based login. The CLI provides a more user friendly way of configuring the tokens for ACL group based login. Signed-off-by: Eero Aaltonen <[email protected]>
eaaltonen
pushed a commit
to eaaltonen/optee_client
that referenced
this pull request
Apr 13, 2021
Add a CLI that can be used to configure tokens for: * standard PIN based login * Access Control List (ACL) based group login The PKCS OP-TEE#11 Cryptographic Token Interface does not include ACL based login. The CLI provides a more user friendly way of configuring the tokens for ACL group based login. Signed-off-by: Eero Aaltonen <[email protected]>
eaaltonen
pushed a commit
to eaaltonen/optee_client
that referenced
this pull request
Apr 14, 2021
Add a CLI that can be used to configure tokens for: * standard PIN based login * Access Control List (ACL) based group login The PKCS OP-TEE#11 Cryptographic Token Interface does not include ACL based login. The CLI provides a more user friendly way of configuring the tokens for ACL group based login. Signed-off-by: Eero Aaltonen <[email protected]>
eaaltonen
pushed a commit
to eaaltonen/optee_client
that referenced
this pull request
Apr 14, 2021
Add a CLI that can be used to configure tokens for: * standard PIN based login * Access Control List (ACL) based group login The PKCS OP-TEE#11 Cryptographic Token Interface does not include ACL based login. The CLI provides a more user friendly way of configuring the tokens for ACL group based login. Signed-off-by: Eero Aaltonen <[email protected]>
eaaltonen
pushed a commit
to eaaltonen/optee_client
that referenced
this pull request
Apr 19, 2021
Add a CLI that can be used to configure tokens for: * standard PIN based login * Access Control List (ACL) based group login The PKCS OP-TEE#11 Cryptographic Token Interface does not include ACL based login. The CLI provides a more user friendly way of configuring the tokens for ACL group based login. Signed-off-by: Eero Aaltonen <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
May 9, 2021
Add support to generate PKCS OP-TEE#1 RSA keys when issuing C_GenerateKeyPair(). Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Current Mechanisms Specification Version 2.40 Plus Errata 01 2.1.4 PKCS OP-TEE#1 RSA key pair generation Signed-off-by: Vesa Jääskeläinen <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
May 9, 2021
Add support for performing RSA signing & verification operations for: - PKCS OP-TEE#1 v1.5 RSA with supplied hash value - Multi stage MD5 - Multi stage SHA-1 - Multi stage SHA-224 - Multi stage SHA-256 - Multi stage SHA-384 - Multi stage SHA-512 Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Current Mechanisms Specification Version 2.40 Plus Errata 01 2.1.6 PKCS OP-TEE#1 v1.5 RSA Signed-off-by: Vesa Jääskeläinen <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
May 9, 2021
Add support for performing RSA PSS signing & verification operations for: - PKCS OP-TEE#1 RSA PSS with supplied hash value - Multi stage SHA-1 - Multi stage SHA-224 - Multi stage SHA-256 - Multi stage SHA-384 - Multi stage SHA-512 Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Current Mechanisms Specification Version 2.40 Plus Errata 01 2.1.10 PKCS OP-TEE#1 RSA PSS Signed-off-by: Vesa Jääskeläinen <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
May 9, 2021
Add support for performing PKCS OP-TEE#1 RSA OAEP encryption & decryption operations for: - MGF1 SHA-1 - MGF1 SHA-224 - MGF1 SHA-256 - MGF1 SHA-384 - MGF1 SHA-512 Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Current Mechanisms Specification Version 2.40 Plus Errata 01 2.1.8 PKCS OP-TEE#1 RSA OAEP Signed-off-by: Vesa Jääskeläinen <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
May 9, 2021
Add support to generate PKCS OP-TEE#1 RSA keys when issuing C_GenerateKeyPair(). Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Current Mechanisms Specification Version 2.40 Plus Errata 01 2.1.4 PKCS OP-TEE#1 RSA key pair generation Signed-off-by: Vesa Jääskeläinen <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
May 9, 2021
Add support for performing RSA signing & verification operations for: - PKCS OP-TEE#1 v1.5 RSA with supplied hash value - Multi stage MD5 - Multi stage SHA-1 - Multi stage SHA-224 - Multi stage SHA-256 - Multi stage SHA-384 - Multi stage SHA-512 Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Current Mechanisms Specification Version 2.40 Plus Errata 01 2.1.6 PKCS OP-TEE#1 v1.5 RSA Signed-off-by: Vesa Jääskeläinen <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
May 9, 2021
Add support for performing RSA PSS signing & verification operations for: - PKCS OP-TEE#1 RSA PSS with supplied hash value - Multi stage SHA-1 - Multi stage SHA-224 - Multi stage SHA-256 - Multi stage SHA-384 - Multi stage SHA-512 Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Current Mechanisms Specification Version 2.40 Plus Errata 01 2.1.10 PKCS OP-TEE#1 RSA PSS Signed-off-by: Vesa Jääskeläinen <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
May 9, 2021
Add support for performing PKCS OP-TEE#1 RSA OAEP encryption & decryption operations for: - MGF1 SHA-1 - MGF1 SHA-224 - MGF1 SHA-256 - MGF1 SHA-384 - MGF1 SHA-512 Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Current Mechanisms Specification Version 2.40 Plus Errata 01 2.1.8 PKCS OP-TEE#1 RSA OAEP Signed-off-by: Vesa Jääskeläinen <[email protected]>
vesajaaskelainen
added a commit
to vesajaaskelainen/optee_client
that referenced
this pull request
May 29, 2021
Add support to generate PKCS OP-TEE#1 RSA keys when issuing C_GenerateKeyPair(). Specified in: PKCS OP-TEE#11 Cryptographic Token Interface Current Mechanisms Specification Version 2.40 Plus Errata 01 2.1.4 PKCS OP-TEE#1 RSA key pair generation Signed-off-by: Vesa Jääskeläinen <[email protected]>
This was referenced Jun 27, 2021
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following patches fix build issues I found when building with: